[aur-requests] [PRQ#18087] Orphan Request for python-pydantic
tonybenoy [1] filed an orphan request for python-pydantic [2]: The package is broken as tests is failing. Also the package is a git version and not from pypi. Also I have a package python-fastapi which is dependent on pydantic. I dont think the maintainer is avaliable. [1] https://aur.archlinux.org/account/tonybenoy/ [2] https://aur.archlinux.org/pkgbase/python-pydantic/
1. Tests are not failing, and if they were, you could use `--nocheck`. 2. Just because the package source comes from a release tarball put on GitHub doesn't make it a `-git` version. 3. Just because the maintainer doesn't respond after 5 days doesn't mean they're unavailable. On Tue, Feb 25, 2020 at 2:09 PM <notify@aur.archlinux.org> wrote:
tonybenoy [1] filed an orphan request for python-pydantic [2]:
The package is broken as tests is failing. Also the package is a git version and not from pypi. Also I have a package python-fastapi which is dependent on pydantic. I dont think the maintainer is avaliable.
[1] https://aur.archlinux.org/account/tonybenoy/ [2] https://aur.archlinux.org/pkgbase/python-pydantic/
Hey Eric, Thanks for your reply. 1) The whole point of checks/test cases are to make sure that the package works correctly. If the whole point is to do --nocheck defeats the purpose of running testcases in the first place. 2) The whole point of asking to add a git flag is so that there can be a pypi version in the case this fails or for someone like me who would use it as a part of starlette and would need the stable release of pypi. 3)The first comment about failing assertion is at 2019-12-20 11:13 (https://aur.archlinux.org/packages/python-pydantic/#comment-721472) hence I assumed that you were unavailable. Thanks and Regards Tony Benoy I'd recommend you encrypt mails sent to me. You can find my pgp key at https://tinyurl.com/y9v2mrt9 On Mar 1 2020, at 9:19 am, Eric Berquist <pentavalentcarbon@gmail.com> wrote:
1. Tests are not failing, and if they were, you could use `--nocheck`. 2. Just because the package source comes from a release tarball put on GitHub doesn't make it a `-git` version. 3. Just because the maintainer doesn't respond after 5 days doesn't mean they're unavailable.
On Tue, Feb 25, 2020 at 2:09 PM <notify@aur.archlinux.org (mailto:notify@aur.archlinux.org)> wrote:
tonybenoy [1] filed an orphan request for python-pydantic [2]:
The package is broken as tests is failing. Also the package is a git version and not from pypi. Also I have a package python-fastapi which is dependent on pydantic. I dont think the maintainer is avaliable.
[1] https://aur.archlinux.org/account/tonybenoy/ [2] https://aur.archlinux.org/pkgbase/python-pydantic/
On 2020-03-01 04:49, Eric Berquist via aur-requests wrote:
1. Tests are not failing, and if they were, you could use `--nocheck`.
When building this package in a clean chroot [1], tests are indeed failing with the error reported by evgfilim1 on 2020-01-29 in the package comments [2].
2. Just because the package source comes from a release tarball put on GitHub doesn't make it a `-git` version.
The package is named correctly, downloading the sources from GitHub instead of PyPI is fine as long as stable releases are used. Cheers, Jonas [1] https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_clean_chroo... [2] https://aur.archlinux.org/packages/python-pydantic/#comment-726821
On 02/03/2020 14.09, Jonas Witschel via aur-requests wrote:
The package is named correctly, downloading the sources from GitHub instead of PyPI is fine as long as stable releases are used.
Suffix pkgname with -cvs, -svn, -hg, -darcs, -bzr, -git etc. unless
Quoting the VCS package guidelines[1]: the package fetches a specific release. I'm pretty sure a package that just fetches a release tarball shouldn't be called -git, as this suffix is reserved for packages that build latest git master. In fact, this package has nothing to do with git except that the sources it fetches are hosted on a site that also hosts git repositories. [1] https://wiki.archlinux.org/index.php/VCS_package_guidelines
On 2020-03-02 14:21, xiretza wrote:
On 02/03/2020 14.09, Jonas Witschel via aur-requests wrote:
The package is named correctly, downloading the sources from GitHub instead of PyPI is fine as long as stable releases are used.
Quoting the VCS package guidelines[1]:
Suffix pkgname with -cvs, -svn, -hg, -darcs, -bzr, -git etc. unless the package fetches a specific release.
I'm pretty sure a package that just fetches a release tarball shouldn't be called -git, as this suffix is reserved for packages that build latest git master. In fact, this package has nothing to do with git except that the sources it fetches are hosted on a site that also hosts git repositories.
Yup, I came to the exactly the same conclusion, which is why I wrote "The package [python-pydantic without -git suffix] is named correctly"...
Thanks for the update Jonas . Tony Benoy I'd recommend you encrypt mails sent to me. You can find my pgp key at https://tinyurl.com/y9v2mrt9 On Mar 2 2020, at 6:39 pm, Jonas Witschel <diabonas@archlinux.org> wrote:
On 2020-03-01 04:49, Eric Berquist via aur-requests wrote:
1. Tests are not failing, and if they were, you could use `--nocheck`.
When building this package in a clean chroot [1], tests are indeed failing with the error reported by evgfilim1 on 2020-01-29 in the package comments [2].
2. Just because the package source comes from a release tarball put on GitHub doesn't make it a `-git` version.
The package is named correctly, downloading the sources from GitHub instead of PyPI is fine as long as stable releases are used.
Cheers, Jonas
[1] https://wiki.archlinux.org/index.php/DeveloperWiki:Building_in_a_clean_chroo... [2] https://aur.archlinux.org/packages/python-pydantic/#comment-726821
Request #18087 has been rejected by diabonas [1]: I confirm that the test suite is failing, but the maintainer is active (and the package is named correctly), see https://lists.archlinux.org/pipermail/aur- requests/2020-March/038118.html Please try to solve the issue in the package comments first before filing an orphan request. [1] https://aur.archlinux.org/account/diabonas/
participants (5)
-
Eric Berquist
-
Jonas Witschel
-
notify＠aur.archlinux.org
-
Tony Benoy
-
xiretza