[aur-requests] [PRQ#11821] Orphan Request for anbox-git
PDesire [1] filed a orphan request for anbox-git [2]: There is no update since January, and the installation is impossible in the current state of code. I have fixed it and pushed my changes to Github in hope people can install Anbox again. Fix: https://github.com/PDesire/anbox- git/commit/5bf532348b5c7c789ab60b615bc80107d09f110d [1] https://aur.archlinux.org/account/PDesire/ [2] https://aur.archlinux.org/pkgbase/anbox-git/
I'm not sure if I even should react seriously to this orphan request. The only two required changes are an additional git repository, after they split it from the main repository a week ago, and an extra compiler flag, only mentioned two weeks ago in the AUR comments, for which already a pull request exited to fix it upstream. Beside I already fixed the PKGBUILD. Kind regards, Iwan On Thu, Jun 14, 2018 at 1:00 PM <notify@aur.archlinux.org> wrote:
PDesire [1] filed a orphan request for anbox-git [2]:
There is no update since January, and the installation is impossible in the current state of code.
I have fixed it and pushed my changes to Github in hope people can install Anbox again.
Fix: https://github.com/PDesire/anbox- git/commit/5bf532348b5c7c789ab60b615bc80107d09f110d
[1] https://aur.archlinux.org/account/PDesire/ [2] https://aur.archlinux.org/pkgbase/anbox-git/
On 06/15/2018 02:46 PM, Iwan Timmer via aur-requests wrote:
I'm not sure if I even should react seriously to this orphan request.
I suggest you treat it with the same seriousness I did in my rejection. :)
The only two required changes are an additional git repository, after they split it from the main repository a week ago, and an extra compiler flag, only mentioned two weeks ago in the AUR comments, for which already a pull request exited to fix it upstream. Beside I already fixed the PKGBUILD.
The compiler flags could be fixed by not building with Werror. :) https://github.com/anbox/anbox/blob/69e75c90e706a38d23aa47fcad72c5c0dad96ddc... They actually make this configurable even! Using build type "None" should do the trick. This is actually recommended since it means CMake should avoid inserting its own optimization flags and rely entirely on environment CFLAGS from makepkg.conf (which I think you just overwrote). -- Eli Schwartz Bug Wrangler and Trusted User
Request #11821 has been rejected by Eschwartz [1]: 1) Your proposed changes are bad quality packaging. 2) The maintainer has updated. 3) You proceeded directly to orphan requests before leaving a comment on the package details. 4) The package has been broken for a grand total of one week, not "since January." You only "fixed" it a day ago yourself. This is hardly grounds for forcibly tearing the package away from an active maintainer. [1] https://aur.archlinux.org/account/Eschwartz/
participants (3)
-
Eli Schwartz
-
Iwan Timmer
-
notify@aur.archlinux.org