buzo [1] filed a orphan request for quassel-light [2]:
I got no response to my comment (bug report) in four months, and this package is outdated for three months, containing critical vulnerabilities (CVE-2018-1000178 and CVE-2018-1000179).
[1] https://aur.archlinux.org/account/buzo/ [2] https://aur.archlinux.org/pkgbase/quassel-light/
Request #12177 has been rejected by Eschwartz [1]:
maintainer updated
notify@aur.archlinux.org schrieb am 12.08.18 16:22:
Request #12177 has been rejected by Eschwartz [1]:
maintainer updated
Yes, the maintainer did indeed two uploads, but the build is still broken (two missing backslashes and an invalid «rm -r», see my comments on https://aur.archlinux.org/pkgbase/quassel-light/). By the way, I just noticed another typo in line 97 of PKGBUILD: quasslel-client should read quassel-client.
Cheers
– Stephan.
On 8/12/18 2:59 PM, Stephan Springer wrote:
notify@aur.archlinux.org schrieb am 12.08.18 16:22:
Request #12177 has been rejected by Eschwartz [1]:
maintainer updated
Yes, the maintainer did indeed two uploads, but the build is still broken (two missing backslashes and an invalid «rm -r», see my comments on https://aur.archlinux.org/pkgbase/quassel-light/). By the way, I just noticed another typo in line 97 of PKGBUILD: quasslel-client should read quassel-client.
Cheers
Oops, I guess I rejected this too soon. Now that I've taken a closer look, it also seems to be missing a makedepends on Qt5... building in a clean chroot results in:
CMake Error at CMakeLists.txt:185 (message): Could NOT find Qt5 >= version 5.2.0!
I've fixed the typo, and added some makedepends. Frankly it's the first time someone noticed that qmake may be not installed.
As for rm -r, it's exactly what the package in community has [1], and my goal was to keep it my PKGBUILD as close to that as possible. And rm -r worked for me just fine.
Can't test building in chroot right away, but will do shortly. I can also add a co-maintainers, no problem there.
1. https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packa...
Cheers, Oleg
On Sun, Aug 12, 2018 at 5:58 PM Eli Schwartz eschwartz@archlinux.org wrote:
On 8/12/18 2:59 PM, Stephan Springer wrote:
notify@aur.archlinux.org schrieb am 12.08.18 16:22:
Request #12177 has been rejected by Eschwartz [1]:
maintainer updated
Yes, the maintainer did indeed two uploads, but the build is still broken (two missing backslashes and an invalid «rm -r», see my comments on https://aur.archlinux.org/pkgbase/quassel-light/). By the way, I just noticed another typo in line 97 of PKGBUILD: quasslel-client should read quassel-client.
Cheers
Oops, I guess I rejected this too soon. Now that I've taken a closer look, it also seems to be missing a makedepends on Qt5... building in a clean chroot results in:
CMake Error at CMakeLists.txt:185 (message): Could NOT find Qt5 >= version 5.2.0!
-- Eli Schwartz Bug Wrangler and Trusted User
On 8/12/18 6:18 PM, Oleg Shparber wrote:
I've fixed the typo, and added some makedepends. Frankly it's the first time someone noticed that qmake may be not installed.
As for rm -r, it's exactly what the package in community has [1], and my goal was to keep it my PKGBUILD as close to that as possible. And rm -r worked for me just fine.
Can't test building in chroot right away, but will do shortly. I can also add a co-maintainers, no problem there.
https://git.archlinux.org/svntogit/community.git/tree/trunk/PKGBUILD?h=packa...
Cheers, Oleg
It also generally needs anything which will eventually be a runtime dependency. If you look at the community package, it also makedepends on qca-qt5 and qt5-script, plus some other things you disabled, but those two need to be dependencies.
You also did not fix the two remaining missing \ characters, right after "_build client" and "_build mono"
The confusing rm -r issue is not so confusing when you realize that the [community] package is actually only removing translations there -- but since qt5-tools was not a dependency, the translations were disabled everywhere.
I guess that comment is out of date. :p
On 8/12/18 6:18 PM, Oleg Shparber wrote:
I've fixed the typo, and added some makedepends. Frankly it's the first time someone noticed that qmake may be not installed.
Not qmake, this uses *cmake*. It's just qt5, like all of it, that was missing.
Also it was indeed noticed:
cyrevolt commented on 2016-05-02 09:07 (edited on 2016-05-02 09:08 by cyrevolt)
You need qt5-script in order to build. It is deprecated according to http://doc.qt.io/qt-5/qtmodules.html though, so I assume the Quassel developers will migrate at some point. :)
Should be all good now, but I can't test atm.
Cheers, Oleg
On Sun, Aug 12, 2018 at 6:44 PM Eli Schwartz eschwartz@archlinux.org wrote:
On 8/12/18 6:18 PM, Oleg Shparber wrote:
I've fixed the typo, and added some makedepends. Frankly it's the first time someone noticed that qmake may be not installed.
Not qmake, this uses *cmake*. It's just qt5, like all of it, that was missing.
Also it was indeed noticed:
cyrevolt commented on 2016-05-02 09:07 (edited on 2016-05-02 09:08 by cyrevolt)
You need qt5-script in order to build. It is deprecated according to http://doc.qt.io/qt-5/qtmodules.html though, so I assume the Quassel developers will migrate at some point. :)
-- Eli Schwartz Bug Wrangler and Trusted User
aur-requests@lists.archlinux.org