February 2018 - Pacman-contrib - lists.archlinux.org

[PATCH] Steal submitting-patches.txt from pacman.git
by Johannes Löthberg 23 Feb '18

23 Feb '18

Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> --- doc/Makefile.am | 6 ++- doc/submitting-patches.txt | 104 +++++++++++++++++++++++++++++++++++++++++++++ 2 files changed, 109 insertions(+), 1 deletion(-) create mode 100644 doc/submitting-patches.txt diff --git a/doc/Makefile.am b/doc/Makefile.am index b67c81d..b44319d 100644 --- a/doc/Makefile.am +++ b/doc/Makefile.am @@ -9,8 +9,12 @@ ASCIIDOC_MANS = \ HTML_MANPAGES = \ pactree.8.html +HTML_OTHER = \ + submitting-patches.html + HTML_DOCS = \ - $(HTML_MANPAGES) + $(HTML_MANPAGES) \ + $(HTML_OTHER) EXTRA_DIST = \ asciidoc.conf \ diff --git a/doc/submitting-patches.txt b/doc/submitting-patches.txt new file mode 100644 index 0000000..cbd8b60 --- /dev/null +++ b/doc/submitting-patches.txt @@ -0,0 +1,104 @@ +Submitting Patches +================== + +This document is here mainly to make the job of those who review patches easier +and is more of a guideline rather than a strict set of rules. However, please +try to follow them as much as you can. + + +Getting the most recent source +------------------------------ +Patches need to be submitted in Git format and are best if they are against the +latest version of the code. There are several helpful tutorials for getting +started with Git if you have not worked with it before. + +* https://git-scm.com/book +* https://www.kernel.org/pub/software/scm/git/docs/gittutorial.html + +The pacman-contrib code can be fetched using the following command: + + git clone git://projects.archlinux.org/pacman-contrib.git + + +Creating your patch +------------------- + +-- +* Use `git commit -s` for creating a commit of your changes. + +The -s allows you to credit yourself by adding a "Signed Off By" line to +indicate who has "signed" the patch - who has approved it. + + Signed-off-by: Aaron Griffin <aaron(a)archlinux.org> + +Please use your real name and email address. Feel free to "scramble" the +address if you're afraid of spam. + +* Describe your patch. + +It helps if you describe the overview and goals of the patch in the git commit +log. This allows others to see what you intended so as to compare it to what +was actually done, and allows better feedback. + +* Use `git format-patch` to create patches. + +Your commit message will be shown above the patch by default when you will use +`git format-patch`, including the signoff line. Sets of multiple patches that +need extra explanation beyond the commit messages may include additional notes +in a cover letter. Individual patches may include additional notes between the +"---" following the commit message and the beginning of the diff. + +-- + +Submitting your patch +--------------------- + +-- +* Send the patch to the https://lists.archlinux.org/listinfo/pacman-contrib[pacman-contrib] mailing list + +The mailing list is the primary queue for review and acceptance. Here you +will get feedback, and let the reviewers know the details of your patch. + +* No MIME, no links, no compression, no attachments. Just plain text. + +Patches should be contained in the actual body of the email. There are many +reasons for this. First, it makes them easier to read with any mail reader, +it allows easier review "at a glance", and most importantly, it allows people +to comment on exact lines of the patch in reply emails. + +`git send-email` allows you to send Git-formatted patches in plain text easily +and is the preferred method for submission to the mailing list. Mail clients, +including Gmail's web interface, have a tendency to break patches by wrapping +lines and/or adjusting whitespace and should be avoided. + +-- + +After you submit +---------------- + +-- +* Don't get discouraged + +Any feedback you get, positive or negative, has nothing to do with you. If a +patch is rejected, try taking the suggestions into account and re-submitting. +We welcome most submissions here, and some may take a bit longer to get +looked over than others. If you think your patch got lost in the shuffle, +send another email to the list in reply to the original asking if anyone has +looked at it yet. + +* Respond to feedback + +When you do get feedback, it usually merits a response, whether this be a +resubmission of the patch with corrections or a follow-up email asking for +clarifications. When neither of these occurs, don't expect your patch to get +further review. The all-volunteer staff don't have time to fix up patches that +aren't their own. When resubmitting patches, update the subject line to reflect +the version number ('[PATCHv2]'), and send it as a reply to the original +thread. When using `git format-patch` you can pass in e.g. -v2 to have it +automatically set the patch prefix appropriately. + +-- + +///// +vim:set ts=4 sw=4 syntax=asciidoc noet spell spelllang=en_us: +///// -- 2.16.2

1 0

[GIT] branch master updated (2a5fc09 -> 30d9671)
by demize＠archlinux.org 22 Feb '18

22 Feb '18

This is an automated email from the git hooks/post-receive script. demize pushed a change to branch master in repository pacman-contrib. from 2a5fc09 pacscripts: Use pacman-conf rather than evaling pacman.conf fragments new 30d9671 paccache: Skip .sig files when globbing candidates for removal The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Graph of new commits: * 30d9671 (HEAD -> master) paccache: Skip .sig files when globbing candidates for removal Detailed log of new commits: commit 30d9671be5c3957df4ed96b40f8e8bb228fbad11 Author: Maxim Baz <lists.archlinux(a)maximbaz.com> Date: Fri Feb 23 00:21:11 2018 +0100 paccache: Skip .sig files when globbing candidates for removal Basically allow any extension after '.tar' except '.sig'. This is needed to correctly count the possible candidates for removal. Signature files are correctly considered later in the script. Fixes FS#57503 Signed-off-by: Maxim Baz <git(a)maximbaz.com> Message-Id: <293a15e6-eedc-d457-fcfd-a7976a9ff7ee(a)maximbaz.com> Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> Summary of changes: src/paccache.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

Re: [pacman-contrib] [PATCH] paccache: Skip .sig files when globbing candidates for removal
by Maxim Baz 22 Feb '18

22 Feb '18

On 02/22/2018 10:05 PM, Johannes Löthberg via pacman-contrib wrote: > Thanks for the patch, but could we use "$PWD"/*.pkg.tar!(*.sig) instead > of using grep for this? It makes the glob a bit more obvious to me as > well. Yes, this is way better, and I confirm that results are the same - will send out the modified patch shortly. On 02/22/2018 11:07 PM, Eli Schwartz via pacman-contrib wrote: > Sorry, this was only partially true. The patch was broken anyways > because of linebreaks and other fun chars, but my issue with it being an > "attachment" is because this list seems to have been configured to relay > messages as message/rfc822. As Johannes pointed out, this is the > technically correct way to preserve DKIM signatures when the mailing > list modifies the From and Subject lines to add the list name into the > subject... if only every client out there (or even most of them) > actually supported it... Yeah, the first patch was completely broken, it was the first time I sent git patches via email and I didn't know about all the problems that email clients cause to the patches :) Was the second patch good though?

3 3

Re: [pacman-contrib] [PATCH] paccache: Skip .sig files when globbing candidates for removal
by Eli Schwartz 22 Feb '18

22 Feb '18

On 02/21/2018 03:17 PM, Maxim Baz via pacman-contrib wrote: This is not a valid patch. It appears to have been sent with: Content-Disposition: inline User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 Did you change `mail.content_disposition_type = 0` and send this email as an attachment by any chance? The raw contents of the (inline attachment) patch are: Basically allow any extension after '.tar' except '.tar.sig'. This is needed to correctly count the possible candidates for removal. Signature files are correctly considered later in the script. Fixes FS#57503 Signed-off-by: Maxim Baz <git(a)maximbaz.com> --- Â src/paccache.sh.in | 2 +- Â 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/paccache.sh.in b/src/paccache.sh.in index 49680be..94bedfa 100644 --- a/src/paccache.sh.in +++ b/src/paccache.sh.in @@ -308,7 +308,7 @@ for cachedir in "${cachedirs[@]}"; do Â Â Â Â # note that these results are returned in an arbitrary order from awk, but Â Â Â Â # they'll be resorted (in summarize) iff we have a verbosity level set. Â Â Â Â IFS=$'\n' read -r -d '' -a cand < \ -Â Â Â Â Â Â <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | pacsort --files | +Â Â Â Â Â Â <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | grep -v '\.sig$' | pacsort --files | Â Â Â Â Â Â Â Â Â Â pkgfilter "$keep" "$scanarch" \ Â Â Â Â Â Â Â Â Â Â Â Â Â "${#whitelist[*]}" "${whitelist[@]}" \ Â Â Â Â Â Â Â Â Â Â Â Â Â "${#blacklist[*]}" "${blacklist[@]}") -- 2.16.2 The best way to send a patch is using git-send-email(1) This way will definitely not work, because of file corruption. -- Eli Schwartz Bug Wrangler and Trusted User

1 1

Re: [pacman-contrib] [PATCH] paccache: Skip .sig files when globbing candidates for removal
by Johannes Löthberg 22 Feb '18

22 Feb '18

Quoting Maxim Baz via pacman-contrib (2018-02-22 00:37:20) > - <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | pacsort --files | > + <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | grep -v '\.sig$' | pacsort --files | Thanks for the patch, but could we use "$PWD"/*.pkg.tar!(*.sig) instead of using grep for this? It makes the glob a bit more obvious to me as well. -- Sincerely, Johannes Löthberg PGP Key ID: 0x50FB9B273A9D0BB5 PGP Key FP: 5134 EF9E AF65 F95B 6BB1 608E 50FB 9B27 3A9D 0BB5 https://theos.kyriasis.com/~kyrias/

1 0

Re: [pacman-contrib] [PATCH] paccache: Skip .sig files when globbing candidates for removal
by Maxim Baz 21 Feb '18

21 Feb '18

Thanks for the heads up, I indeed configured Thunderbird incorrectly. I've submitted another attempt, this time I tested that `git am *.eml` is able to process my patch. On 02/21/2018 09:59 PM, Eli Schwartz via pacman-contrib wrote: > This is not a valid patch. It appears to have been sent with: > > Content-Disposition: inline > User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 > Thunderbird/52.6.0 > > Did you change `mail.content_disposition_type = 0` and send this email > as an attachment by any chance?

1 0

[PATCH] paccache: Skip .sig files when globbing candidates for removal
by Maxim Baz 21 Feb '18

21 Feb '18

Basically allow any extension after '.tar', but not '.tar.sig'. This is needed to correctly count the possible candidates for removal. Signature files are correctly considered later in the script. Fixes FS#57503 Signed-off-by: Maxim Baz <git(a)maximbaz.com> --- src/paccache.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/paccache.sh.in b/src/paccache.sh.in index 49680be..37cd5e0 100644 --- a/src/paccache.sh.in +++ b/src/paccache.sh.in @@ -308,7 +308,7 @@ for cachedir in "${cachedirs[@]}"; do # note that these results are returned in an arbitrary order from awk, but # they'll be resorted (in summarize) iff we have a verbosity level set. IFS=$'\n' read -r -d '' -a cand < \ - <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | pacsort --files | + <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | grep -v '\.sig$' | pacsort --files | pkgfilter "$keep" "$scanarch" \ "${#whitelist[*]}" "${whitelist[@]}" \ "${#blacklist[*]}" "${blacklist[@]}") -- 2.16.2

1 0

[PATCH] paccache: Skip .sig files when globbing candidates for removal
by Maxim Baz 21 Feb '18

21 Feb '18

Basically allow any extension after '.tar' except '.tar.sig'. This is needed to correctly count the possible candidates for removal. Signature files are correctly considered later in the script. Fixes FS#57503 Signed-off-by: Maxim Baz <git(a)maximbaz.com> --- src/paccache.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/paccache.sh.in b/src/paccache.sh.in index 49680be..94bedfa 100644 --- a/src/paccache.sh.in +++ b/src/paccache.sh.in @@ -308,7 +308,7 @@ for cachedir in "${cachedirs[@]}"; do # note that these results are returned in an arbitrary order from awk, but # they'll be resorted (in summarize) iff we have a verbosity level set. IFS=$'\n' read -r -d '' -a cand < \ - <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | pacsort --files | + <(printf '%s\n' "$PWD"/*.pkg.tar?(.+([^.])) | grep -v '\.sig$' | pacsort --files | pkgfilter "$keep" "$scanarch" \ "${#whitelist[*]}" "${whitelist[@]}" \ "${#blacklist[*]}" "${blacklist[@]}") -- 2.16.2

1 0

[GIT] branch master updated (28e29dd -> 2a5fc09)
by demize＠archlinux.org 14 Feb '18

14 Feb '18

This is an automated email from the git hooks/post-receive script. demize pushed a change to branch master in repository pacman-contrib. from 28e29dd Migrate scripts from manual parsing of pacman.conf, to use of pacman-conf new 2a5fc09 pacscripts: Use pacman-conf rather than evaling pacman.conf fragments The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Graph of new commits: * 2a5fc09 (HEAD -> master) pacscripts: Use pacman-conf rather than evaling pacman.conf fragments Detailed log of new commits: commit 2a5fc098adb9508ddd0649889a14cbcc9bd91501 Author: Johannes Löthberg <johannes(a)kyriasis.com> Date: Wed Feb 14 20:40:00 2018 +0100 pacscripts: Use pacman-conf rather than evaling pacman.conf fragments Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> Summary of changes: src/pacscripts.sh.in | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[pacman-contrib] [PATCH] pacscripts: Use pacman-conf rather than evaling pacman.conf fragments
by Johannes Löthberg 14 Feb '18

14 Feb '18

Signed-off-by: Johannes Löthberg <johannes(a)kyriasis.com> --- src/pacscripts.sh.in | 21 +++++++++------------ 1 file changed, 9 insertions(+), 12 deletions(-) diff --git a/src/pacscripts.sh.in b/src/pacscripts.sh.in index 68c9441..17e2625 100644 --- a/src/pacscripts.sh.in +++ b/src/pacscripts.sh.in @@ -27,18 +27,6 @@ set -o errexit declare -r myname='pacscripts' declare -r myver='@PACKAGE_VERSION@' -conf="@sysconfdir@/pacman.conf" - -if [ ! -r "$conf" ]; then - echo "ERROR: unable to read $conf" - exit 1 -fi - -eval $(awk '/DBPath/ {print $1$2$3}' "$conf") -eval $(awk '/CacheDir/ {print $1$2$3}' "$conf") -pac_db="${DBPath:-@localstatedir@/lib/pacman}/local" -pac_cache="${CacheDir:-@localstatedir@/cache/pacman/pkg}" - error() { local mesg=$1; shift printf "==> $(gettext "ERROR:") ${mesg}\n" "$@" >&2 @@ -59,6 +47,15 @@ usage() { echo "Example: ${myname} gconf-editor-3.0.1-3-x86_64.pkg.tar.xz" } + +if ! DBPath="$(pacman-conf DBPath)"; then + error "unable to read @sysconfdir@/pacman.conf" + exit 1 +fi +CacheDir="$(pacman-conf CacheDir)" +pac_db="${DBPath:-@localstatedir@/lib/pacman}/local" +pac_cache="${CacheDir:-@localstatedir@/cache/pacman/pkg}" + version() { printf "%s %s\n" "$myname" "$myver" echo 'Copyright (c) 2009 Giulio "giulivo" Fidente <giulivo.navigante(a)gmail.com>' -- 2.16.1

2 2