March 2020 - Pacman-contrib - lists.archlinux.org

[PATCH] pactree: Fix redundant arrows in Graphviz output
by Sebastian Jakubiak 15 Mar '20

15 Mar '20

Fix an issue where a dependency and a package providing it were connected more than once in --graph output. The code supposed to prevent that did not always work due to using dangling pointers. Signed-off-by: Sebastian Jakubiak <jakseb.dev(a)gmail.com> --- This is how one can find a package to reproduce the bug: for pkg in `pacman -Qq`; do pactree -g $pkg | sort | uniq -c | awk '$1 != 1' | grep '' && { echo $pkg; break; } done Originally, I wanted to check if the value returned by strdup() is not null, but the existing code (line 217) does not do that, so I don't either. src/pactree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pactree.c b/src/pactree.c index 9f074fe..cf83326 100644 --- a/src/pactree.c +++ b/src/pactree.c @@ -232,7 +232,7 @@ static int register_syncs(void) static void cleanup(int ret) { alpm_list_free(walked); - alpm_list_free(provisions); + FREELIST(provisions); alpm_release(handle); exit(ret); @@ -412,7 +412,7 @@ static void print_graph(const char *parentname, const char *pkgname, const char printf("\"%s\" -> \"%s\" [color=chocolate4];\n", parentname, depname); if(pkgname && strcmp(depname, pkgname) != 0 && !alpm_list_find_str(provisions, depname)) { printf("\"%s\" -> \"%s\" [arrowhead=none, color=grey];\n", depname, pkgname); - provisions = alpm_list_add(provisions, (char *)depname); + provisions = alpm_list_add(provisions, strdup(depname)); } } else if(pkgname) { printf("\"%s\" -> \"%s\" [color=chocolate4];\n", parentname, pkgname); -- 2.25.0

2 1

[GIT] branch master updated (e77e13b -> c7be863)
by Daniel M. Capella 15 Mar '20

15 Mar '20

This is an automated email from the git hooks/post-receive script. polyzen pushed a change to branch master in repository pacman-contrib. from e77e13b pactree: Improve command line validation new c7be863 pactree: Fix redundant arrows in Graphviz output The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Graph of new commits: * c7be863 (HEAD -> master) pactree: Fix redundant arrows in Graphviz output Detailed log of new commits: commit c7be86316c1ee7bea8a892f618fb9f1fc126c7f7 Author: Sebastian Jakubiak <jakseb.dev(a)gmail.com> Date: Mon Mar 9 19:22:06 2020 +0100 pactree: Fix redundant arrows in Graphviz output Fix an issue where a dependency and a package providing it were connected more than once in --graph output. The code supposed to prevent that did not always work due to using dangling pointers. Signed-off-by: Sebastian Jakubiak <jakseb.dev(a)gmail.com> Signed-off-by: Daniel M. Capella <polyzen(a)archlinux.org> Summary of changes: src/pactree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0

[PATCH] pactree: Improve command line validation
by Sebastian Jakubiak 09 Mar '20

09 Mar '20

Exit with non-zero status when the command line specifies more than one package or an unknown option. Fixes FS#64589. Signed-off-by: Sebastian Jakubiak <jakseb.dev(a)gmail.com> --- If I may, I would like to use this occasion to suggest a feature: the ability to process multiple packages by pactree. I am sending a patch for that in reply to this email. src/pactree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/pactree.c b/src/pactree.c index 5bc0032..9f074fe 100644 --- a/src/pactree.c +++ b/src/pactree.c @@ -346,7 +346,6 @@ static int parse_options(int argc, char *argv[]) version(); cleanup(0); case 'h': - case '?': usage(); cleanup(0); default: @@ -355,7 +354,8 @@ static int parse_options(int argc, char *argv[]) } } - if(!argv[optind]) { + if(!argv[optind] || argv[optind + 1]) { + usage(); return 1; } -- 2.25.0

2 6

[GIT] branch master updated (a4e69ca -> e77e13b)
by Daniel M. Capella 06 Mar '20

06 Mar '20

This is an automated email from the git hooks/post-receive script. polyzen pushed a change to branch master in repository pacman-contrib. from a4e69ca pactree: Add --gpgdir, set the gpg directory new e77e13b pactree: Improve command line validation The 1 revisions listed above as "new" are entirely new to this repository and will be described in separate emails. The revisions listed as "add" were already present in the repository and have only been added to this reference. Graph of new commits: * e77e13b (HEAD -> master) pactree: Improve command line validation Detailed log of new commits: commit e77e13b03e17f07d9cc504cfb09088a2c01c390b Author: Sebastian Jakubiak <jakseb.dev(a)gmail.com> Date: Fri Mar 6 03:10:37 2020 +0100 pactree: Improve command line validation Exit with non-zero status when the command line specifies more than one package or an unknown option. Fixes FS#64589. Signed-off-by: Sebastian Jakubiak <jakseb.dev(a)gmail.com> Signed-off-by: Daniel M. Capella <polyzen(a)archlinux.org> Summary of changes: src/pactree.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- To stop receiving notification emails like this one, please contact the administrator of this repository.

1 0