Ideas for new functionality in pacdiff
Hello, I recently discovered pacdiff, which has proved to be an simple, excellent tool for taking care of pacfiles. There are a couple minor improvements I thought of, and would like to hear opinions on them before writing a patch. Currently, before pacdiff asks for the user's choice of action, it will compare the original file to the pacfile. If the files are identical, it will delete the pacfile. My idea is to perform this check after the user views the diff. This way, the user may merge all changes with their DIFFPROG, and the pacfile will automatically be deleted when they close their editor. If the files still differ, functionality would remain the same as it is currently. The second idea is simply a way to swap the sides that the files appear on in DIFFPROG. Personally, I would prefer having the pacfile on the right, but it is currently on the left. Having an argument for this seems reasonable to me. These would both be very simple changes, but would make the program a lot nicer, for me at least. Thanks, John Leuenhagen
Hey, Excerpts from John A. Leuenhagen's message of September 29, 2020 5:11:
Currently, before pacdiff asks for the user's choice of action, it will compare the original file to the pacfile. If the files are identical, it will delete the pacfile. My idea is to perform this check after the user views the diff. This way, the user may merge all changes with their DIFFPROG, and the pacfile will automatically be deleted when they close their editor. If the files still differ, functionality would remain the same as it is currently.
Sure, that makes sense.
The second idea is simply a way to swap the sides that the files appear on in DIFFPROG. Personally, I would prefer having the pacfile on the right, but it is currently on the left. Having an argument for this seems reasonable to me.
I'm not so sure about this however. Since the pacnew is the current packaged state, the actual file is the one that differs from the default state, so I believe that the current order overall makes more semantic sense. If more people show interest in having the other order available, we could add an option for it however. -- Sincerely, Johannes Löthberg :: SA0DEM
Hi, Thanks for the response. I'll go ahead and write up a patch for the first thing. As for the second, what you said does make sense. I suppose the reason that I prefer the other way is that it feels to me like I'm merging the default file into my personal file. Otherwise (with current functionality), it feels like the reverse. On 10/5/20 12:59 PM, Johannes Löthberg wrote:
Hey,
Excerpts from John A. Leuenhagen's message of September 29, 2020 5:11:
Currently, before pacdiff asks for the user's choice of action, it will compare the original file to the pacfile. If the files are identical, it will delete the pacfile. My idea is to perform this check after the user views the diff. This way, the user may merge all changes with their DIFFPROG, and the pacfile will automatically be deleted when they close their editor. If the files still differ, functionality would remain the same as it is currently.
Sure, that makes sense.
The second idea is simply a way to swap the sides that the files appear on in DIFFPROG. Personally, I would prefer having the pacfile on the right, but it is currently on the left. Having an argument for this seems reasonable to me.
I'm not so sure about this however. Since the pacnew is the current packaged state, the actual file is the one that differs from the default state, so I believe that the current order overall makes more semantic sense.
If more people show interest in having the other order available, we could add an option for it however.
participants (2)
-
Johannes Löthberg
-
John A. Leuenhagen