Fwd: Re: [PATCH] paclist: Allow listing packages from multiple repos at once
-------- Forwarded Message -------- Subject: Re: [PATCH] paclist: Allow listing packages from multiple repos at once Date: Sun, 4 Aug 2019 19:06:42 +0200 From: Lars Rustand <rustand.lars@gmail.com> To: Johannes Löthberg <johannes@kyriasis.com> Thank you for the feedback. Here follows a corrected patch. Is there a chance this will be merged? Signed-off-by: Lars Rustand <rustand.lars@gmail.com> --- src/paclist.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/paclist.sh.in b/src/paclist.sh.in index efd47af..5c4c896 100644 --- a/src/paclist.sh.in +++ b/src/paclist.sh.in @@ -25,7 +25,7 @@ usage() { echo printf "List all packages installed from a given repository\n" "${myname}" echo - printf "Usage: %s <repository>\n" "${myname}" + printf "Usage: %s <repository> ...\n" "${myname}" echo printf "Example: %s testing\n" "${myname}" } @@ -49,7 +49,7 @@ elif [[ $1 = -@(V|-version) ]]; then exit 0 fi -pacman -Sl $1 | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; +pacman -Sl "$@" | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; /\[.*[[:digit:]]+]$/ {print $2,substr($NF, 1, length($NF) - 1)}' # exit with pacman's return value, not awk's -- 2.22.0
This patch is quite broken and will not apply. Seems Thunderbird has fudged it up. Please resend it using e.g. `git send-email` to make sure it's not broken by the MUA. (The manpage has an example for configuring it for GMail use.) Excerpts from Lars Rustand's message of August 7, 2019 21:44:
-------- Forwarded Message --------
Subject: Re: [PATCH] paclist: Allow listing packages from multiple repos at once Date: Sun, 4 Aug 2019 19:06:42 +0200 From: Lars Rustand <rustand.lars@gmail.com> To: Johannes Löthberg <johannes@kyriasis.com>
Thank you for the feedback. Here follows a corrected patch. Is there a chance this will be merged?
Signed-off-by: Lars Rustand <rustand.lars@gmail.com> --- src/paclist.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/paclist.sh.in b/src/paclist.sh.in index efd47af..5c4c896 100644 --- a/src/paclist.sh.in +++ b/src/paclist.sh.in @@ -25,7 +25,7 @@ usage() { echo printf "List all packages installed from a given repository\n" "${myname}" echo - printf "Usage: %s <repository>\n" "${myname}" + printf "Usage: %s <repository> ...\n" "${myname}" echo printf "Example: %s testing\n" "${myname}" } @@ -49,7 +49,7 @@ elif [[ $1 = -@(V|-version) ]]; then exit 0 fi
-pacman -Sl $1 | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; +pacman -Sl "$@" | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; /\[.*[[:digit:]]+]$/ {print $2,substr($NF, 1, length($NF) - 1)}'
# exit with pacman's return value, not awk's
-- 2.22.0
-------- Forwarded Message --------
Subject: Re: [PATCH] paclist: Allow listing packages from multiple repos at once Date: Sun, 4 Aug 2019 19:06:42 +0200 From: Lars Rustand <rustand.lars@gmail.com> To: Johannes Löthberg <johannes@kyriasis.com>
Thank you for the feedback. Here follows a corrected patch. Is there a chance this will be merged?
Signed-off-by: Lars Rustand <rustand.lars@gmail.com> --- src/paclist.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/paclist.sh.in b/src/paclist.sh.in index efd47af..5c4c896 100644 --- a/src/paclist.sh.in +++ b/src/paclist.sh.in @@ -25,7 +25,7 @@ usage() { echo printf "List all packages installed from a given repository\n" "${myname}" echo - printf "Usage: %s <repository>\n" "${myname}" + printf "Usage: %s <repository> ...\n" "${myname}" echo printf "Example: %s testing\n" "${myname}" } @@ -49,7 +49,7 @@ elif [[ $1 = -@(V|-version) ]]; then exit 0 fi
-pacman -Sl $1 | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; +pacman -Sl "$@" | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; /\[.*[[:digit:]]+]$/ {print $2,substr($NF, 1, length($NF) - 1)}'
# exit with pacman's return value, not awk's
-- 2.22.0
-- Sincerely, Johannes Löthberg :: SA0DEM
Signed-off-by: Lars Rustand <rustand.lars@gmail.com> --- src/paclist.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/paclist.sh.in b/src/paclist.sh.in index efd47af..5c4c896 100644 --- a/src/paclist.sh.in +++ b/src/paclist.sh.in @@ -25,7 +25,7 @@ usage() { echo printf "List all packages installed from a given repository\n" "${myname}" echo - printf "Usage: %s <repository>\n" "${myname}" + printf "Usage: %s <repository> ...\n" "${myname}" echo printf "Example: %s testing\n" "${myname}" } @@ -49,7 +49,7 @@ elif [[ $1 = -@(V|-version) ]]; then exit 0 fi -pacman -Sl $1 | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; +pacman -Sl "$@" | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; /\[.*[[:digit:]]+]$/ {print $2,substr($NF, 1, length($NF) - 1)}' # exit with pacman's return value, not awk's -- 2.22.0
Excerpts from Lars Rustand's message of August 8, 2019 7:20:
Signed-off-by: Lars Rustand <rustand.lars@gmail.com> --- src/paclist.sh.in | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/paclist.sh.in b/src/paclist.sh.in index efd47af..5c4c896 100644 --- a/src/paclist.sh.in +++ b/src/paclist.sh.in @@ -25,7 +25,7 @@ usage() { echo printf "List all packages installed from a given repository\n" "${myname}" echo - printf "Usage: %s <repository>\n" "${myname}" + printf "Usage: %s <repository> ...\n" "${myname}" echo printf "Example: %s testing\n" "${myname}" } @@ -49,7 +49,7 @@ elif [[ $1 = -@(V|-version) ]]; then exit 0 fi
-pacman -Sl $1 | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; +pacman -Sl "$@" | awk '/\[.*[[:alpha:]]+]$/ {print $2,$3}; /\[.*[[:digit:]]+]$/ {print $2,substr($NF, 1, length($NF) - 1)}'
# exit with pacman's return value, not awk's -- 2.22.0
Merged, thanks. -- Sincerely, Johannes Löthberg :: SA0DEM
participants (2)
-
Johannes Löthberg
-
Lars Rustand