Pacman-dev October 2010

pacman-dev@lists.archlinux.org

22 participants
58 discussions

Re: [pacman-dev] Contributing BSD patches upstream
by Dan McGee 14 Oct '10

14 Oct '10

On Wed, Oct 6, 2010 at 6:38 AM, Nezmer <me(a)nezmer.info> wrote: > On Tue, Oct 05, 2010 at 07:56:53PM -0500, Dan McGee wrote: >> On Tue, Oct 5, 2010 at 6:03 PM, Dan McGee <dpmcgee(a)gmail.com> wrote: >> > Hey, >> > >> > I noticed you did some merges and updates on your pacman-bsd branch >> > today (http://gitorious.org/pacman-bsd/pacman-bsd). Have you thought >> > about trying to get some of this work into the main branch of code so >> > you don't have to maintain as much? I know we've already taken in a >> > few things, like the makepkg colors checking stuff, but it might be >> > nice to ensure we are as portable as possible out of the box. >> > >> > I CC-ed in Allan because a lot of these are touchups to makepkg. I >> > know we may not seem to move quickly at times, but we do appreciate >> > patches and contributions from others. >> >> My quick review of the differences picked out these things as stuff >> that should/could be looked at to improve compatibility and >> correctness: >> >> 1. DBPath/CacheDir parsing in scripts/ and contrib/ >> 2. Fix bash regexes: =~ should never have RHS quotes >> 3. Hardcoded '.tar.gz' in some contrib/ scripts >> 4. contrib/, use configurable etc/ directory (sysconfdir I believe) >> 5. bsdtar binary location, don't assume it is on path? >> 6. Use of seq (not a bash builtin) >> 7. makepkg: strip binary location hardcoded, perhaps use $STRIP >> 8. makepkg: mknod vs. mkfifo >> 9. bash shebang in scripts >> >> -Dan > > Just saw this. A very good summary. > > I'm welling to answer any questions or put together any patch you are > interested to take. I'd basically say anything that is in the above list is fair game for patches. #2 and #3 are pretty low-hanging, non-invasive stuff if you'd like somewhere to start. I think I just handled #6 as we only used it in one contrib script; patch going to the ML. This message is also going to the ML so we can maybe get some discussion going there. -Dan

4 6

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v3.4.1-9-g3a06a9f
by dan＠archlinux.org 14 Oct '10

14 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, maint has been updated via 3a06a9fa9fafe705bfb79c23dd75ca226b22026c (commit) from 283ef6519aa20b8c63c9b916573b5f243ff7be2e (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- ----------------------------------------------------------------------- Summary of changes: lib/libalpm/be_package.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.1-131-gde5f438
by dan＠archlinux.org 14 Oct '10

14 Oct '10

1 0

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.1-122-gef32aa0
by dan＠archlinux.org 14 Oct '10

14 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via ef32aa0219146866b7f7e55c95afc327819dd6cf (commit) via 68b50c81c79bcf01db0fd66ff523f32cc0dc67e9 (commit) via 24d77291da93fcd5d09df2b1d1d05474616f18a5 (commit) via 5b17d8f27d9a490a461eb2946f7c209d42c5762e (commit) via fbcadebcab57d59e460368fb6ed48bba0bbfb8a1 (commit) via d39248120e4b30e56fe052dcf5973e16e482975e (commit) via e464339e3bd37e9bdb2c8d13fa29408a1123f620 (commit) via 448f78c067955d617c302f322a2dc6507cb6eb13 (commit) via 5717c7d508db463ec178a83e852dc5e89212bd15 (commit) via 149ab6b2723c41954b638cd603e5d4ac392c8659 (commit) via 4a8e396a58219fcc6d906ce7c2bb4c4b904bd64c (commit) via 5e61f077357de1767efada259aeb824bcbfe0086 (commit) via fc32faaa6ab4081e2046b2a81e4f9949af2f7282 (commit) via 5b2de3d8ecceea0eed3124e50792400adce4e95a (commit) via 6eedf06fcc224648155bc5253d6fe1975be8da00 (commit) via 96e277cfd935d680d6309311260fe79567324e9c (commit) via 0909a72000b03332c5203b16b6a4e862c0662e03 (commit) via c56b576f6fef464f82f425219ef386fe8b742899 (commit) via efbae3cfcbd8e401084cb26853bbe46120daea4d (commit) via 522ef5e981580a52ee0ffa37178d7ddf116ebd51 (commit) via b9a531c2d7e3eefab5d987d83a1cb869e1220fac (commit) via 6cebd4e6028f717663cda0af1221f3ac74d5ab9f (commit) via d1126db1281596ba8ea960bfa963e86731d28b5e (commit) via 49176461a6b476e673e232075c95f07963750f74 (commit) via a7dc3875f15f9600e011c313c8846de6af3a2c8c (commit) from 5fcb005ebd270c1ecff3403695680145253961a2 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ef32aa0219146866b7f7e55c95afc327819dd6cf Author: Dan McGee <dan(a)archlinux.org> Date: Wed Oct 13 23:09:20 2010 -0500 Small tweaks after backend merge Just a few small things I noticed looking through the code. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 68b50c81c79bcf01db0fd66ff523f32cc0dc67e9 Merge: 6eedf06 24d7729 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Oct 13 22:46:04 2010 -0500 Merge remote branch 'allan/backend' commit 24d77291da93fcd5d09df2b1d1d05474616f18a5 Author: Allan McRae <allan(a)archlinux.org> Date: Wed Oct 13 21:18:03 2010 +1000 Only write to local repos We do not write to sync repos so kill the code for that. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5b17d8f27d9a490a461eb2946f7c209d42c5762e Author: Allan McRae <allan(a)archlinux.org> Date: Mon Oct 11 15:10:26 2010 +1000 Clean-up parsing sync database Remove unnecessary parsing of fields not found in sync desc file. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit fbcadebcab57d59e460368fb6ed48bba0bbfb8a1 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Oct 11 15:06:10 2010 +1000 Clean-up parsing local database Remove unnecessary parsing of fields not found in local desc files. Leave %FORCE% parsing as this likely will make an appearance in desc files in the future. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d39248120e4b30e56fe052dcf5973e16e482975e Author: Allan McRae <allan(a)archlinux.org> Date: Mon Oct 11 14:57:16 2010 +1000 Remove lazy loading of deltas Local packages do not have deltas so remove lazy loading of delta information. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit e464339e3bd37e9bdb2c8d13fa29408a1123f620 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Oct 11 14:05:07 2010 +1000 Move and rename splitname The splitname function is a general utility function and so is better suited to util.h. Rename it to _alpm_splitname to indicate it is an internal libalpm function as was the case prior to splitting local and sync db handling. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 448f78c067955d617c302f322a2dc6507cb6eb13 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Oct 11 13:47:18 2010 +1000 Restrict visibility of checkdbdir and get_pkgpath These functions are only needed by be_local and were only promoted to db.{h,c} as part of the splitting of handling the local and sync dbs. Move them into be_local.c and make them static again. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5717c7d508db463ec178a83e852dc5e89212bd15 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Jul 10 00:52:50 2010 +1000 Clean up all old database files and directories Clean-up the previous download location of the sync database and any old extracted sync database directories which are unneeded with the tar-db backend. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 149ab6b2723c41954b638cd603e5d4ac392c8659 Author: Allan McRae <allan(a)archlinux.org> Date: Sun Oct 10 15:25:45 2010 +1000 Only download sync databases As the sync databases are read directly from the tarball, we no longer need to extract them. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4a8e396a58219fcc6d906ce7c2bb4c4b904bd64c Author: Allan McRae <allan(a)archlinux.org> Date: Sun Oct 10 14:49:10 2010 +1000 Parse sync database Read in package information for a tar based sync database. Do not use lazy loading for sync db. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5e61f077357de1767efada259aeb824bcbfe0086 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Oct 9 23:31:29 2010 +1000 Populate sync db from archive Read in list of packages for sync db from tar archive. Breaks reading in _alpm_sync_db_read and a lot of pactests (which is expected as they do not handle sync db in archives...). Signed-off-by: Allan McRae <allan(a)archlinux.org> commit fc32faaa6ab4081e2046b2a81e4f9949af2f7282 Author: Allan McRae <allan(a)archlinux.org> Date: Sat Oct 9 20:16:15 2010 +1000 Completely separate local and sync db handling Put the db_operations struct to use and completely split the handling of the sync and local databases. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 5b2de3d8ecceea0eed3124e50792400adce4e95a Author: Allan McRae <allan(a)archlinux.org> Date: Wed Oct 13 18:04:07 2010 +1000 Separate be_files into be_sync and be_local The file be_files.c is "split" to be_local.c and be_sync.c in order to achieve separate handling of sync and local databases. Some basic clean-up of functions that are only of use for local or sync databases has been performed and some rough function renaming in duplicated code has been performed to prevent compilation errors. However, most of the clean-up and final separation of sync and local db handling occurs in following patches. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 6eedf06fcc224648155bc5253d6fe1975be8da00 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Oct 13 17:50:54 2010 -0500 Fix bash shell location check BASH is defined when you are actually using bash during configure, which sucks because it ends up being '/bin/sh', messing up all of our scripts. Change the name of the variable we use in configure, and also ensure we get a full path to the executable by using AC_PATH_PROGS rather than AC_CHECK_PROGS. Finally, change the variable name everywhere we use it. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 96e277cfd935d680d6309311260fe79567324e9c Author: Allan McRae <allan(a)archlinux.org> Date: Wed Oct 13 22:56:35 2010 +1000 Move db cache handling functions These will be needed for the handling of both local and sync database caches, so put them in a common location. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 0909a72000b03332c5203b16b6a4e862c0662e03 Author: Allan McRae <allan(a)archlinux.org> Date: Wed Oct 13 17:55:55 2010 +1000 Move database handling utility functions Move splitname, checkdbdir, get_pkgpath into db.{h,c} as these will be needed to parse both the local and sync databases during the initial splitting. They will be moved out of db.{h,c} at to more appropriate locations at a later stage. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit c56b576f6fef464f82f425219ef386fe8b742899 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Aug 2 14:40:04 2010 +1000 Fix documentation syntax and typo Signed-off-by: Allan McRae <allan(a)archlinux.org> commit efbae3cfcbd8e401084cb26853bbe46120daea4d Author: Dan McGee <dan(a)archlinux.org> Date: Sat Jul 10 21:06:21 2010 -0500 Initial hack at a DB operations struct It doesn't do a whole lot yet, but these type of operations will potentially be different for the DBs we load. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 522ef5e981580a52ee0ffa37178d7ddf116ebd51 Author: Dan McGee <dan(a)archlinux.org> Date: Mon May 12 07:49:01 2008 +1000 Move the cache stuff where it should be Cache bullshit only has relevance to be_files, so move it there. Signed-off-by: Dan McGee <dan(a)archlinux.org> [Allan: BIG rebase] Signed-off-by: Allan McRae <allan(a)archlinux.org> commit b9a531c2d7e3eefab5d987d83a1cb869e1220fac Author: Dan McGee <dan(a)archlinux.org> Date: Sun May 11 16:49:01 2008 -0500 Move changelog functions to callback struct Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 6cebd4e6028f717663cda0af1221f3ac74d5ab9f Author: Dan McGee <dan(a)archlinux.org> Date: Sun May 11 16:00:33 2008 -0500 Complete rework of package accessor logic Hopefully we've finally arrived at package handling nirvana, or at least this commit will get us a heck of a lot closer. The former method of getting the depends list for a package was the following: 1. call alpm_pkg_get_depends() 2. this method would check if the package came from the cache 3. if so, ensure our cache level is correct, otherwise call db_load 4. finally return the depends list Why did this suck? Because getting the depends list from the package shouldn't care about whether the package was loaded from a file, from the 'package cache', or some other system which we can't even use because the damn thing is so complicated. It should just return the depends list. So what does this commit change? It adds a pointer to a struct of function pointers to every package for all of these 'package operations' as I've decided to call them (I know, sounds completely straightforward, right?). So now when we call an alpm_pkg_get-* function, we don't do any of the cache logic or anything else there- we let the actual backend handle it by delegating all work to the method at pkg->ops->get_depends. Now that be_package has achieved equal status with be_files, we can treat packages from these completely different load points differently. We know a package loaded from a zip file will have all of its fields populated, so we can set up all its accessor functions to be direct accessors. On the other hand, the packages loaded from the local and sync DBs are not always fully-loaded, so their accessor functions are routed through the same logic as before. Net result? More code. However, this code now make it roughly 52 times easier to open the door to something like a read-only tar.gz database backend. Are you still reading? I'm impressed. Looking at the patch will probably be clearer than this long-winded explanation. Signed-off-by: Dan McGee <dan(a)archlinux.org> [Allan: rebase and adjust] Signed-off-by: Allan McRae <allan(a)archlinux.org> commit d1126db1281596ba8ea960bfa963e86731d28b5e Author: Dan McGee <dan(a)archlinux.org> Date: Sun May 11 12:00:18 2008 -0500 Allow local and sync db to be treated separately Implement this seemingly simple change in package.h: typedef enum _pmpkgfrom_t { - PKG_FROM_CACHE = 1, - PKG_FROM_FILE + PKG_FROM_FILE = 1, + PKG_FROM_LOCALDB, + PKG_FROM_SYNCDB } pmpkgfrom_t; which requires flushing out several assumptions from around the codebase with regards to usage of the PKG_FROM_CACHE value. Make some changes where required to allow the switch, and now the correct value should be set (via a crude hack) depending on whether a package was loaded as an entry in a local db or a sync db. This patch underwent some big rebasing from Allan and Dan. Signed-off-by: Dan McGee <dan(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 49176461a6b476e673e232075c95f07963750f74 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jul 7 09:39:39 2010 -0500 Unify caching concerns in package accessors Move almost all of the caching related stuff into a single #define (which should maybe even just be a static function) so we don't duplicate logic all over the place. This also makes the code a heck of a lot shorter and means further changes to this stuff don't have to touch each and every getter function. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit a7dc3875f15f9600e011c313c8846de6af3a2c8c Author: Dan McGee <dan(a)archlinux.org> Date: Tue Oct 12 08:26:50 2010 -0500 contrib/ follow-up work * Add a .gitignore file * Use the same 'GEN' output we have in the scripts/ Makefile when doing our edits on the .in files * Remove PKGBUILD.vim and vimprojects from our edit list, they have no need to be in the list Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: configure.ac | 2 +- contrib/.gitignore | 9 + contrib/Makefile.am | 11 +- contrib/{PKGBUILD.vim.in => PKGBUILD.vim} | 0 contrib/bacman.in | 2 +- contrib/pacdiff.in | 2 +- contrib/pacscripts.in | 2 +- contrib/pactree.in | 2 +- contrib/{vimprojects.in => vimprojects} | 0 contrib/wget-xdelta.sh.in | 2 +- lib/libalpm/Makefile.am | 4 +- lib/libalpm/add.c | 7 +- lib/libalpm/{be_files.c => be_local.c} | 704 ++++++++++++++--------------- lib/libalpm/be_package.c | 111 +++++ lib/libalpm/be_sync.c | 440 ++++++++++++++++++ lib/libalpm/cache.c | 291 ------------ lib/libalpm/cache.h | 44 -- lib/libalpm/conflict.c | 1 - lib/libalpm/db.c | 271 ++++++++++-- lib/libalpm/db.h | 48 ++- lib/libalpm/deps.c | 1 - lib/libalpm/package.c | 417 +++++------------- lib/libalpm/package.h | 63 +++- lib/libalpm/po/POTFILES.in | 3 +- lib/libalpm/remove.c | 5 +- lib/libalpm/sync.c | 3 +- lib/libalpm/trans.c | 1 - lib/libalpm/util.c | 45 ++ lib/libalpm/util.h | 2 + scripts/Makefile.am | 2 +- scripts/makepkg.sh.in | 2 +- scripts/pacman-optimize.sh.in | 2 +- scripts/pkgdelta.sh.in | 2 +- scripts/rankmirrors.sh.in | 2 +- scripts/repo-add.sh.in | 2 +- src/pacman/sync.c | 32 +- 36 files changed, 1431 insertions(+), 1106 deletions(-) create mode 100644 contrib/.gitignore rename contrib/{PKGBUILD.vim.in => PKGBUILD.vim} (100%) rename contrib/{vimprojects.in => vimprojects} (100%) rename lib/libalpm/{be_files.c => be_local.c} (59%) create mode 100644 lib/libalpm/be_sync.c delete mode 100644 lib/libalpm/cache.c delete mode 100644 lib/libalpm/cache.h hooks/post-receive -- The official pacman repository

2 1

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.1-88-g46ffd34
by dan＠archlinux.org 14 Oct '10

14 Oct '10

4 6

[pacman-dev] We've broken the bash
by Dan McGee 14 Oct '10

14 Oct '10

I think this was alluded to a while back, but we are starting to show some problems with our naming scheme and bash variable/function naming rules: /usr/bin/makepkg: line 1831: declare: `package_python-xlwt': not a valid identifier With latest makepkg built from git. -Dan

4 13

[pacman-dev] tar based sync backend implemented!
by Allan McRae 13 Oct '10

13 Oct '10

Hi, I have implemented the reading directly from the db tarball for sync databases. See the patchset on by "backend" branch (http://projects.archlinux.org/users/allan/pacman.git/log/?h=backend). Some of the changes are quite big (e.g. 9 files changed, 2184 insertions, 1571 deletions), but that is mainly moving and duplicating code in the process of splitting the handling of local and sync dbs. There is still _a lot_ of clean-up to be done in the code, but it is fully functional. This breaks pactests... lots of pactests... but that is expected as the pactest suite does not understand a tar based sync db. I would like help fixing that as I get lost in the pactest code. Anyway, here is the timing for some operations. First time is with dropped caches, the second running it again with the db cached. pacman -Syy (download time ~15-20sec) old: 1m25.197s, 0m22.445s new: 0m19.391s, 0m22.084s (download speed variation...) pacman -Sl extra old: 0m6.973s, 0m0.193s new: 0m3.974s, 0m0.390s pacman -Ss pacman old: 0m11.521s, 0m0.395s new: 0m4.171s, 0m0.477s pacman -Si pacman old: 0m6.067s, 0m0.101s new: 0m1.929s, 0m0.437s echo "n" | pacman -Su (five packages to update) old: 0m17.823s, 0m0.306s new: 0m10.577s, 0m0.489s So the tar backend gets some quite significant speed gains in the uncached case, and has marginal losses when the db is cached. Note that the entire sync db is read and parsed no matter the (sync) operation. That explains the difference in the cases with the db cached. This could be adjusted to read the package list (pkgname, pkgver-pkgrel) first and read the desc/depends files for the entire db or a single package as needed but that is probably distant future stuff... Allan

1 2

[pacman-dev] [RFC] pactree rewrite in C
by Dave Reisner 13 Oct '10

13 Oct '10

The recent patchwork over the weekend inspired me to take a closer look at pactree. My first impression was that it would be a great candidate for a rewrite in C. http://www.github.com/falconindy/pactree Results are entertaining: # bash version $ time pactree -r glib2 >/dev/null real 0m2.538s user 0m1.593s sys 0m0.435s # C rewrite $ time ./pactree -r glib2 >/dev/null real 0m0.016s user 0m0.007s sys 0m0.009s I'm finding that it's even slightly more accurate than the bash version WRT to reverse dependency tracking as it's hooking into alpm's alpm_pkg_compute_required_by() instead of wandering through the file hierarchy. It's feature complete compared to the Bash version, aside from the export to graphviz. The only functional change I've made is: when walking reverse depends, don't re-walk already visited dependencies. I thought this was a logical change given the behavior of the standard dependency tracking. I'm happy to offer this up for merging if desirable. There's a few ugly bits in the code I still want to refactor -- if anyone has any comments or criticisms, they're very welcome. d

3 10

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.4.1-97-g5fcb005
by dan＠archlinux.org 12 Oct '10

12 Oct '10

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 5fcb005ebd270c1ecff3403695680145253961a2 (commit) via 827258f32ee898ed5422bc9219d9a42bd9bd2360 (commit) via 0ff2a9149711b9179d288f579c792890cd81d79b (commit) via 05f0a28932c1acab7a9ddb58435d69626dad54da (commit) via bce3c8efc7a2d187984aa0e7037307b99c217fd7 (commit) via 7d937772313a796f4c0bff76bf1bd7d78f8ccb5a (commit) via c9179b09db405e89093c07756d8e674ff8119ea2 (commit) via 53b41afbe8c47afaa5daf94f4e66cab81bd024cd (commit) via fb79d58109ff5a55ac3cea83607eb41e70456b17 (commit) from 46ffd342a4255916a9599692b5969ae4cd85a156 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 5fcb005ebd270c1ecff3403695680145253961a2 Author: Jakob Gruber <jakob.gruber(a)gmail.com> Date: Fri Oct 8 22:59:30 2010 +0200 CLI args: stricter/better parsing In the following, the letters SRUDQ refer to the corresponding pacman operations. Most of the work in this commit is about removing as many options as possible from the global section and moving them to where they actually belong. Additionally, --ignore{,group} are added to U and --dbonly is added to S. --dbonly added to S --asdeps moved to S/U/D --asexplicit moved to S/U/D --print-format moved to S/U/R --noprogressbar moved to S/U/R --noscriptlet moved to S/U/R --ignorepkg added to U --ignoregrp added to U -d moved to S/U/R (--nodeps) and Q (--deps) -p moved to S/U/R (--print) and Q (--file) -f moved to S/U Signed-off-by: Xavier Chantry <chantry.xavier(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 827258f32ee898ed5422bc9219d9a42bd9bd2360 Author: Jakob Gruber <jakob.gruber(a)gmail.com> Date: Fri Oct 8 22:34:17 2010 +0200 CLI args: reorganize parsing Split parsing of CLI arguments into separate functions: parsearg_op (operations) parsearg_global (global options) parsearg_{database,query,remove,sync,deptest,upgrade} Organization strictly follows the manpage (even where the manpage is incorrect) - these cases will be fixed in the following commits. Switch cases are copy/pasted and statements unrelated to chosen operation are deleted. Parsing logic adjusted as follows: 1) Parse operation 2) If we can bail out early (duplicate op, help/version requested) do so 3) Parse arguments again: foreach arg: if arg is operation: continue tryparse_args_specific_to_op if unsuccessful tryparse_args_global if unsuccessful print error message and exit Signed-off-by: Xavier Chantry <chantry.xavier(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 0ff2a9149711b9179d288f579c792890cd81d79b Author: Dan McGee <dan(a)archlinux.org> Date: Mon Oct 11 20:20:06 2010 -0500 util: fall cleaning on single file programs * Add a bunch of static declarations where possible * Fix void functions to be proper syntax, e.g. void func(void) * Consistency fixes (such as argv references) * Remove dead str_cmp() function from testdb * Remove unneeded config.h header includes * vercmp: remove completely unnecessary string copying Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 05f0a28932c1acab7a9ddb58435d69626dad54da Author: Nezmer <git(a)nezmer.info> Date: Tue Oct 12 02:23:16 2010 +0300 Use sysconfdir, localstatedir, BASH instead of hardcoded values This applies to contrib/ files, our scripts, and the documentation. Dan: fix 'make clean' in contrib/ directory. Signed-off-by: Nezmer <git(a)nezmer.info> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit bce3c8efc7a2d187984aa0e7037307b99c217fd7 Author: Nezmer <git(a)nezmer.info> Date: Tue Oct 12 00:20:57 2010 +0300 Add .in extension to files in contrib This is needed If we want to use sysconfdir,localstatedir and other variables. Signed-off-by: Nezmer <git(a)nezmer.info> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 7d937772313a796f4c0bff76bf1bd7d78f8ccb5a Author: Xavier Chantry <chantry.xavier(a)gmail.com> Date: Mon Oct 11 18:28:35 2010 +0200 repo-add: more informative delta messages - Print an error if database entry was not found and delta entry cannot be added - More informative line when delta entry is added (oldfile -> newfile) Signed-off-by: Xavier Chantry <chantry.xavier(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit c9179b09db405e89093c07756d8e674ff8119ea2 Author: Xavier Chantry <chantry.xavier(a)gmail.com> Date: Mon Oct 11 17:08:00 2010 +0200 repo-add: add delta generation This allows deltas to be generated at repo-add invocation time as opposed to just added to the database. It will generate the delta from the package version currently in the database. Signed-off-by: Xavier Chantry <shiningxc(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 53b41afbe8c47afaa5daf94f4e66cab81bd024cd Author: Xavier Chantry <chantry.xavier(a)gmail.com> Date: Wed Aug 18 23:53:29 2010 +0200 pactest: fix typo in ignore001 Signed-off-by: Xavier Chantry <chantry.xavier(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit fb79d58109ff5a55ac3cea83607eb41e70456b17 Author: Nezmer <git(a)nezmer.info> Date: Mon Oct 11 22:16:49 2010 +0300 makepkg: Use mkfifo instead of GNU-only 'mknod <file> p' 'mknod <file> p' is apparently GNU-only. Looking at coreutils' source code, It just calls mkfifo. This one line patch should fix makepkg logging in non-GNU systems. Signed-off-by: Nezmer <git(a)nezmer.info> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: configure.ac | 1 + contrib/Makefile.am | 33 ++- contrib/{PKGBUILD.vim => PKGBUILD.vim.in} | 0 contrib/{bacman => bacman.in} | 16 +- contrib/{bash_completion => bash_completion.in} | 0 contrib/{pacdiff => pacdiff.in} | 2 +- contrib/{paclist => paclist.in} | 0 contrib/{pacscripts => pacscripts.in} | 8 +- contrib/{pacsearch => pacsearch.in} | 0 contrib/{pactree => pactree.in} | 10 +- contrib/{vimprojects => vimprojects.in} | 0 contrib/{wget-xdelta.sh => wget-xdelta.sh.in} | 10 +- contrib/{zsh_completion => zsh_completion.in} | 18 +- doc/Makefile.am | 1 + doc/makepkg.8.txt | 2 +- doc/pacman.8.txt | 30 +- doc/pacman.conf.5.txt | 12 +- scripts/Makefile.am | 1 + scripts/makepkg.sh.in | 4 +- scripts/pacman-optimize.sh.in | 2 +- scripts/pkgdelta.sh.in | 2 +- scripts/rankmirrors.sh.in | 4 +- scripts/repo-add.sh.in | 36 ++- src/pacman/pacman.c | 453 +++++++++++++++-------- src/util/cleanupdelta.c | 8 +- src/util/testdb.c | 17 +- src/util/testpkg.c | 6 +- src/util/vercmp.c | 23 +- test/pacman/tests/ignore001.py | 2 +- test/pacman/tests/pacman005.py | 3 - 30 files changed, 438 insertions(+), 266 deletions(-) rename contrib/{PKGBUILD.vim => PKGBUILD.vim.in} (100%) rename contrib/{bacman => bacman.in} (95%) rename contrib/{bash_completion => bash_completion.in} (100%) rename contrib/{pacdiff => pacdiff.in} (99%) rename contrib/{paclist => paclist.in} (100%) rename contrib/{pacscripts => pacscripts.in} (95%) rename contrib/{pacsearch => pacsearch.in} (100%) rename contrib/{pactree => pactree.in} (97%) rename contrib/{vimprojects => vimprojects.in} (100%) rename contrib/{wget-xdelta.sh => wget-xdelta.sh.in} (88%) rename contrib/{zsh_completion => zsh_completion.in} (92%) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] util: fall cleaning on single file programs
by Dan McGee 12 Oct '10

12 Oct '10

* Add a bunch of static declarations where possible * Fix void functions to be proper syntax, e.g. void func(void) * Consistency fixes (such as argv references) * Remove dead str_cmp() function from testdb * Remove unneeded config.h header includes * vercmp: remove completely unnecessary string copying Signed-off-by: Dan McGee <dan(a)archlinux.org> --- src/util/cleanupdelta.c | 8 ++++---- src/util/testdb.c | 17 ++++++----------- src/util/testpkg.c | 6 ++---- src/util/vercmp.c | 23 +++++++---------------- 4 files changed, 19 insertions(+), 35 deletions(-) diff --git a/src/util/cleanupdelta.c b/src/util/cleanupdelta.c index ffcfaba..c1ef18c 100644 --- a/src/util/cleanupdelta.c +++ b/src/util/cleanupdelta.c @@ -49,7 +49,7 @@ void output_cb(pmloglevel_t level, char *fmt, va_list args) } -void checkpkgs(alpm_list_t *pkglist) +static void checkpkgs(alpm_list_t *pkglist) { alpm_list_t *i, *j; for(i = pkglist; i; i = alpm_list_next(i)) { @@ -63,7 +63,7 @@ void checkpkgs(alpm_list_t *pkglist) } } -void checkdbs(char *dbpath, alpm_list_t *dbnames) { +static void checkdbs(char *dbpath, alpm_list_t *dbnames) { char syncdbpath[PATH_MAX]; pmdb_t *db = NULL; alpm_list_t *i; @@ -82,14 +82,14 @@ void checkdbs(char *dbpath, alpm_list_t *dbnames) { } -void usage() { +static void usage(void) { fprintf(stderr, "usage:\n"); fprintf(stderr, "\t%s [-b <pacman db>] core extra ... : check the listed sync databases\n", BASENAME); exit(1); } -int main(int argc, char **argv) +int main(int argc, char *argv[]) { char *dbpath = DBPATH; int a = 1; diff --git a/src/util/testdb.c b/src/util/testdb.c index 45a2626..28f2b2b 100644 --- a/src/util/testdb.c +++ b/src/util/testdb.c @@ -30,11 +30,6 @@ #define BASENAME "testdb" -int str_cmp(const void *s1, const void *s2) -{ - return(strcmp(s1, s2)); -} - static void cleanup(int signum) { if(alpm_release() == -1) { fprintf(stderr, "error releasing alpm: %s\n", alpm_strerrorlast()); @@ -100,7 +95,7 @@ static int db_test(char *dbpath, int local) return(ret); } -int checkdeps(alpm_list_t *pkglist) +static int checkdeps(alpm_list_t *pkglist) { alpm_list_t *data, *i; int ret = 0; @@ -119,7 +114,7 @@ int checkdeps(alpm_list_t *pkglist) return(ret); } -int checkconflicts(alpm_list_t *pkglist) +static int checkconflicts(alpm_list_t *pkglist) { alpm_list_t *data, *i; int ret = 0; @@ -135,7 +130,7 @@ int checkconflicts(alpm_list_t *pkglist) return(ret); } -int check_localdb(char *dbpath) { +static int check_localdb(char *dbpath) { char localdbpath[PATH_MAX]; int ret = 0; pmdb_t *db = NULL; @@ -159,7 +154,7 @@ int check_localdb(char *dbpath) { return(ret); } -int check_syncdbs(char *dbpath, alpm_list_t *dbnames) { +static int check_syncdbs(char *dbpath, alpm_list_t *dbnames) { char syncdbpath[PATH_MAX]; int ret = 0; pmdb_t *db = NULL; @@ -190,7 +185,7 @@ cleanup: return(ret); } -void usage() { +static void usage(void) { fprintf(stderr, "usage:\n"); fprintf(stderr, "\t%s [-b <pacman db>] : check the local database\n", BASENAME); @@ -199,7 +194,7 @@ void usage() { exit(1); } -int main(int argc, char **argv) +int main(int argc, char *argv[]) { int ret = 0; char *dbpath = DBPATH; diff --git a/src/util/testpkg.c b/src/util/testpkg.c index d86fb1e..6fc0ce0 100644 --- a/src/util/testpkg.c +++ b/src/util/testpkg.c @@ -17,8 +17,6 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ -#include "config.h" - #include <stdio.h> /* printf */ #include <stdarg.h> /* va_list */ @@ -26,7 +24,7 @@ #define BASENAME "testpkg" -static void output_cb(pmloglevel_t level, char *fmt, va_list args) +void output_cb(pmloglevel_t level, char *fmt, va_list args) { if(fmt[0] == '\0') { return; @@ -39,7 +37,7 @@ static void output_cb(pmloglevel_t level, char *fmt, va_list args) vprintf(fmt, args); } -int main(int argc, char **argv) +int main(int argc, char *argv[]) { int retval = 1; /* default = false */ pmpkg_t *pkg = NULL; diff --git a/src/util/vercmp.c b/src/util/vercmp.c index 959dc13..8a785bb 100644 --- a/src/util/vercmp.c +++ b/src/util/vercmp.c @@ -18,20 +18,16 @@ * along with this program. If not, see <http://www.gnu.org/licenses/>. */ -#include "config.h" - #include <stdio.h> /* printf */ #include <string.h> /* strncpy */ #define BASENAME "vercmp" -#define MAX_LEN 255 - /* forward declaration, comes from vercmp.o in libalpm source that is linked in * directly so we don't have any library deps */ int alpm_pkg_vercmp(const char *a, const char *b); -static void usage() +static void usage(void) { fprintf(stderr, "usage: %s <ver1> <ver2>\n\n", BASENAME); fprintf(stderr, "return values:\n"); @@ -42,8 +38,8 @@ static void usage() int main(int argc, char *argv[]) { - char s1[MAX_LEN] = ""; - char s2[MAX_LEN] = ""; + const char *s1 = ""; + const char *s2 = ""; int ret; if(argc == 1) { @@ -56,16 +52,11 @@ int main(int argc, char *argv[]) usage(); return(0); } - if(argc > 1) { - strncpy(s1, argv[1], MAX_LEN); - s1[MAX_LEN -1] = '\0'; - } if(argc > 2) { - strncpy(s2, argv[2], MAX_LEN); - s2[MAX_LEN -1] = '\0'; - } else { - printf("0\n"); - return(0); + s2 = argv[2]; + } + if(argc > 1) { + s1 = argv[1]; } ret = alpm_pkg_vercmp(s1, s2); -- 1.7.3.1

1 0

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Pacman-dev October 2010