June 2011 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH 0/2] Minor tweaks to download code
by Dave Reisner 01 Jun '11

01 Jun '11

Just a couple fixes for the download code. I'm not entirely convinced that the values hard coded in patch 2/2 are appropriate, so I'll say that its up for discussion. I know that we have folks who insist on using dial-up, so we need to be aware of this as well. Based on the source of curl, it seems to be a comparison of the average speed over the life of the transfer against the low speed limit, so this would actually be elongated on larger transfers. Regardless, this should address bug reports such as FS#23690 and FS#15369. dave

2 4

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v3.5.2-195-g8f1c873
by dan＠archlinux.org 01 Jun '11

01 Jun '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via 8f1c873b5f07f42a8bdc65bb03097790135a9c94 (commit) via 5842dad7e7b6265067ca8f286f945b3e7e76c321 (commit) via 41da2253366b6f641fc3e986817ee617c9e18df3 (commit) via fe9804a96d9e50a44e549c7be9189152e20893c5 (commit) via aad57cc06ac60dc8fdcff9bea811e990d64f74d3 (commit) via ac1726788c4bf9ae335df9f69f14a5f80208c413 (commit) via 1855b3073a33874a80d64e40296050641d63cd63 (commit) via 7b261675801822a1c5922dd982f012f91dd737f8 (commit) via e711e5b9501adcb692c65e7d358ae5b0e5bcfb57 (commit) via 65c18807350b2bedff0546b839fd5cd0004a6d4f (commit) from 11fb9c767450dc193bbeef755c228aa620df75d9 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 8f1c873b5f07f42a8bdc65bb03097790135a9c94 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 1 12:56:38 2011 -0500 doc: monospace attribute escape fixes Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 5842dad7e7b6265067ca8f286f945b3e7e76c321 Author: Pang Yan Han <pangyanhan(a)gmail.com> Date: Sat May 28 22:37:35 2011 +0800 pacman-key: print default gpgdir in usage Signed-off-by: Pang Yan Han <pangyanhan(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 41da2253366b6f641fc3e986817ee617c9e18df3 Merge: fe9804a aad57cc Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 1 12:13:49 2011 -0500 Merge branch 'maint' commit fe9804a96d9e50a44e549c7be9189152e20893c5 Author: Pang Yan Han <pangyanhan(a)gmail.com> Date: Sat May 28 22:37:32 2011 +0800 Update pacman manpage and pacman.conf for gpgdir pacman.8.txt --gpgdir section is updated based on the pacman.conf manpage pacman.conf is updated to include the default GPGDir Signed-off-by: Pang Yan Han <pangyanhan(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 7b261675801822a1c5922dd982f012f91dd737f8 Author: Pang Yan Han <pangyanhan(a)gmail.com> Date: Sat May 28 22:37:31 2011 +0800 Let pacman -v print GPG Dir Signed-off-by: Pang Yan Han <pangyanhan(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: doc/Makefile.am | 4 ++-- doc/asciidoc.conf | 4 ++++ doc/makepkg.8.txt | 2 +- doc/pacman-key.8.txt | 4 ++-- doc/pacman.8.txt | 15 ++++++++------- doc/pacman.conf.5.txt | 14 +++++++------- etc/pacman.conf.in | 1 + lib/libalpm/alpm_list.c | 2 +- lib/libalpm/handle.c | 2 -- lib/libalpm/trans.c | 3 ++- scripts/pacman-key.sh.in | 2 +- src/pacman/pacman.c | 1 + 12 files changed, 30 insertions(+), 24 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [GIT] The official pacman repository branch, maint, updated. v3.5.2-20-gaad57cc
by dan＠archlinux.org 01 Jun '11

01 Jun '11

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, maint has been updated via aad57cc06ac60dc8fdcff9bea811e990d64f74d3 (commit) via ac1726788c4bf9ae335df9f69f14a5f80208c413 (commit) via 1855b3073a33874a80d64e40296050641d63cd63 (commit) via e711e5b9501adcb692c65e7d358ae5b0e5bcfb57 (commit) via 65c18807350b2bedff0546b839fd5cd0004a6d4f (commit) from f2c4e7e55220addef0581d1c38cc7363b5a0884c (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit aad57cc06ac60dc8fdcff9bea811e990d64f74d3 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 1 12:11:31 2011 -0500 doc: fix attribute substitution in monospaced text When I switched all paths to use `` formatting, I didn't realize substitution didn't work in these quote marks. Use ++ instead to ensure attributes are substituted where appropriate. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit ac1726788c4bf9ae335df9f69f14a5f80208c413 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 1 12:10:32 2011 -0500 doc: update Makefile for new asciidoc resource location Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 1855b3073a33874a80d64e40296050641d63cd63 Author: Dan McGee <dan(a)archlinux.org> Date: Wed Jun 1 11:46:13 2011 -0500 doc: add a few more escapes and fix usage of {} These addditional attributes come from the git asciidoc.conf file. Also, fix a place where we used {treename} without escaping the braces, causing the generated manpage to be missing text. Signed-off-by: Dan McGee <dan(a)archlinux.org> commit e711e5b9501adcb692c65e7d358ae5b0e5bcfb57 Author: Pang Yan Han <pangyanhan(a)gmail.com> Date: Tue May 24 11:25:13 2011 +0800 alpm_list: fix typo in doxygen comment Signed-off-by: Pang Yan Han <pangyanhan(a)gmail.com> Signed-off-by: Dan McGee <dan(a)archlinux.org> commit 65c18807350b2bedff0546b839fd5cd0004a6d4f Author: Dan McGee <dan(a)archlinux.org> Date: Thu May 19 17:42:22 2011 -0500 Bail early if we don't have a valid lockfile path This addresses FS#24292. If one does the bad thing of not checking pm_errno after calling set_dbpath(), you may not realize the initialization process went wrong and calling trans_init() resulted in a segfault. If we don't have a lockfile path, bail out and have trans_init() fail. Also remove a ALPM_LOG_FUNC call that was causing pm_errno to return "no handle"; this was due to a log call in the handle setup (whereby the log attempts to use a callback attached to the handle). Signed-off-by: Dan McGee <dan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: doc/Makefile.am | 4 ++-- doc/asciidoc.conf | 4 ++++ doc/makepkg.8.txt | 2 +- doc/pacman.8.txt | 4 ++-- doc/pacman.conf.5.txt | 12 ++++++------ lib/libalpm/alpm_list.c | 2 +- lib/libalpm/handle.c | 2 -- lib/libalpm/trans.c | 3 ++- 8 files changed, 18 insertions(+), 15 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH 4/6] Add --verify option for signature level
by Pang Yan Han 01 Jun '11

01 Jun '11

The --verify option allows the user to change pacman's default signature verification level. It can take in one of "Always", "Optional" or "Verify". Signed-off-by: Pang Yan Han <pangyanhan(a)gmail.com> --- This is a reroll after Remy suggested that it's better to set the signature verification level supplied from the command line in setlibpaths(). A new field is introduced in struct config which stores what the user passes to the --verify option at the command line. Is it possible for us to change option_verifysig to compare to non-caps versions of "Always", "Optional" and "Never"? src/pacman/conf.c | 14 ++++++++++++++ src/pacman/conf.h | 4 +++- src/pacman/pacman.c | 4 ++++ 3 files changed, 21 insertions(+), 1 deletions(-) diff --git a/src/pacman/conf.c b/src/pacman/conf.c index 370ec51..869c005 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -68,6 +68,7 @@ int config_free(config_t *oldconfig) free(oldconfig->rootdir); free(oldconfig->dbpath); free(oldconfig->logfile); + free(oldconfig->sigverify); free(oldconfig->xfercommand); free(oldconfig->print_format); free(oldconfig); @@ -474,6 +475,19 @@ static int setlibpaths(void) } } + /* Set the signature verification level to what the user requested */ + if(config->sigverify) { + pgp_verify_t verify = option_verifysig(config->sigverify); + if (verify != PM_PGP_VERIFY_UNKNOWN) { + ret = alpm_option_set_default_sigverify(verify); + if(ret != 0) { + pm_printf(PM_LOG_ERROR, _("problem setting sigverify '%s' (%s)\n"), + config->sigverify, alpm_strerrorlast()); + return ret; + } + } + } + /* add a default cachedir if one wasn't specified */ if(alpm_option_get_cachedirs() == NULL) { alpm_option_add_cachedir(CACHEDIR); diff --git a/src/pacman/conf.h b/src/pacman/conf.h index 76c76cf..d08f83c 100644 --- a/src/pacman/conf.h +++ b/src/pacman/conf.h @@ -41,6 +41,7 @@ typedef struct __config_t { char *dbpath; char *logfile; char *gpgdir; + char *sigverify; /* TODO how to handle cachedirs? */ unsigned short op_q_isfile; @@ -111,7 +112,8 @@ enum { OP_ASEXPLICIT, OP_ARCH, OP_PRINTFORMAT, - OP_GPGDIR + OP_GPGDIR, + OP_VERIFY }; /* clean method */ diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 8458c97..1e58890 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -438,6 +438,9 @@ static int parsearg_global(int opt) config->logfile = strndup(optarg, PATH_MAX); break; case OP_NOCONFIRM: config->noconfirm = 1; break; + case OP_VERIFY: + config->sigverify = strdup(optarg); + break; case 'b': check_optarg(); config->dbpath = strdup(optarg); @@ -635,6 +638,7 @@ static int parseargs(int argc, char *argv[]) {"arch", required_argument, 0, OP_ARCH}, {"print-format", required_argument, 0, OP_PRINTFORMAT}, {"gpgdir", required_argument, 0, OP_GPGDIR}, + {"verify", required_argument, 0, OP_VERIFY}, {0, 0, 0, 0} }; -- 1.7.5.rc0.101.g3d23c

2 1

[pacman-dev] Patch: Clean up API
by Kerrick Staley 01 Jun '11

01 Jun '11

All, This patch fixes API inconsistencies: A) All references to PGP were removed within names, because such reference is unnecessary. All references to GnuPG's home directory were changed to 'gpgdir' (as opposed to e.g. 'signaturedir'), because this directory is specific to GnuPG. B) makepkg and repo-add now use -S/--sign for signing packages. I didn't find an issue with --nosign and --key. C) Config file directives were not changed because they make enough sense as-is. Unlike functions and flags, you don't have to memorize directives, because they are already given in the config file when you edit it. D) A bug was fixed: repo-add previously used the user's GPG directory when verifying the signature on an old database. It now uses pacman's directory for this purpose. I added a flag --gpgdir to allow configuration of this directory. The patch conflicts with Pang Yan Han's patches. Yan Han, could you please merge the two patch sets? Can the patch be reviewed quickly and either accepted or rejected with suggestions for correction? I realize it should be broken into smaller patches, but I'm inexperienced with git, and I didn't want to wait until tomorrow to submit the changes. The patch is signed-off by: Kerrick Staley <mail(a)kerrickstaley.com> -Kerrick Staley

4 4

[pacman-dev] Finishing off the package signing issue -- Update
by Kerrick Staley 01 Jun '11

01 Jun '11

> Hello Kerrick, > > As you say, pacman is not a system, just lines of code, it provides > tools to use gpg as a security system, and any system discussions go > to arch-general(a)archlinux.org. Few Archlinux developers, as far as I > know, read the pacman-dev mailing-list. > > Rémy. > Rémy, OK, I suppose I am wrong. Understood. -Kerrick Staley

1 0