January 2013 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH 0/4] Redo path flexibility patches.
by Allan McRae 23 Jan '13

23 Jan '13

There was some concern about potential security implications of calling execvp and the ability to get a root shell. Good to see this was mentioned in the six months between the patches being sent to the mailing list and when they were committed (passive-agressive Allan!) All those patches are reverted (commits 4a8c2852, 993700bc, bb4d2b72, 60b192e3) in the first patch which is not being sent. Then the pactests are refixed only allowing full paths to the scriptlet shell and the path to ldconfig is made configurable. Allan McRae (4): Revert execvp and related commits pactest: handle non-default scriptlet shells Remove leading / for pactest paths Make path to ldconfig configurable Makefile.am | 1 + configure.ac | 16 +++++++++++++--- lib/libalpm/util.c | 17 ++++++++++------- test/pacman/pactest.py | 8 ++++++-- test/pacman/pmdb.py | 1 + test/pacman/pmenv.py | 1 + test/pacman/pmfile.py | 1 + test/pacman/pmpkg.py | 1 + test/pacman/pmrule.py | 1 + test/pacman/pmtest.py | 28 +++++++++------------------- test/pacman/tests/ldconfig001.py | 2 +- test/pacman/tests/ldconfig002.py | 2 +- test/pacman/tests/ldconfig003.py | 2 +- test/pacman/tests/sync700.py | 2 +- test/pacman/util.py | 1 + 15 files changed, 49 insertions(+), 35 deletions(-) -- 1.8.1.1

1 2

[pacman-dev] [PATCH] [paccache] Fix printing of paths
by William Giokas 21 Jan '13

21 Jan '13

Originally printed a leading \ before all path names as the `' would be removed during the make. Using '' should be just as good as using `'. paccache.sh.in: die "cachedir \`%s' does not exist or is not a directory" "$cachedir" paccache die "cachedir \%s does not exist or is not a directory" "$cachedir" Signed-off-by: William Giokas <1007380(a)gmail.com> --- contrib/paccache.sh.in | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/contrib/paccache.sh.in b/contrib/paccache.sh.in index 15b7dff..dfac1cb 100644 --- a/contrib/paccache.sh.in +++ b/contrib/paccache.sh.in @@ -132,7 +132,7 @@ summarize() { if (( delete )); then printf -v output 'finished: %d packages removed' "$filecount" elif (( move )); then - printf -v output "finished: %d packages moved to \`%s'" "$filecount" "$movedir" + printf -v output "finished: %d packages moved to '%s'" "$filecount" "$movedir" elif (( dryrun )); then if (( verbose )); then msg "Candidate packages:" @@ -266,10 +266,10 @@ case $(( dryrun+delete+move )) in esac [[ -d $cachedir ]] || - die "cachedir \`%s' does not exist or is not a directory" "$cachedir" + die "cachedir '%s' does not exist or is not a directory" "$cachedir" [[ $movedir && ! -d $movedir ]] && - die "move-to directory \`%s' does not exist or is not a directory" "$movedir" + die "move-to directory '%s' does not exist or is not a directory" "$movedir" if (( move || delete )); then # make it an absolute path since we're about to chdir @@ -278,7 +278,7 @@ if (( move || delete )); then fi # unlikely that this will fail, but better make sure -cd "$cachedir" >/dev/null || die "failed to chdir to \`%s'" "$cachedir" +cd "$cachedir" >/dev/null || die "failed to chdir to '%s'" "$cachedir" # note that these results are returned in an arbitrary order from awk, but # they'll be resorted (in summarize) iff we have a verbosity level set. -- 1.8.1.1.250.geacf011

2 1

[pacman-dev] [PATCH 3/4] Remove leading / for pactest paths
by Allan McRae 20 Jan '13

20 Jan '13

The leading / makes the pactest suite look for the file in the users filesystem. This meant the ldconfig tests always passed (even when broken in pacman...). Signed-off-by: Allan McRae <allan(a)archlinux.org> --- test/pacman/tests/ldconfig001.py | 2 +- test/pacman/tests/ldconfig002.py | 2 +- test/pacman/tests/ldconfig003.py | 2 +- test/pacman/tests/sync700.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/test/pacman/tests/ldconfig001.py b/test/pacman/tests/ldconfig001.py index a264326..a97f28c 100644 --- a/test/pacman/tests/ldconfig001.py +++ b/test/pacman/tests/ldconfig001.py @@ -6,4 +6,4 @@ self.args = "-U %s" % p.filename() self.addrule("PACMAN_RETCODE=0") -self.addrule("FILE_EXIST=/etc/ld.so.cache") +self.addrule("FILE_EXIST=etc/ld.so.cache") diff --git a/test/pacman/tests/ldconfig002.py b/test/pacman/tests/ldconfig002.py index 2628dc7..07f2ec6 100644 --- a/test/pacman/tests/ldconfig002.py +++ b/test/pacman/tests/ldconfig002.py @@ -10,4 +10,4 @@ self.addrule("PACMAN_RETCODE=0") self.addrule("PKG_VERSION=dummy|1.0-2") -self.addrule("FILE_EXIST=/etc/ld.so.cache") +self.addrule("FILE_EXIST=etc/ld.so.cache") diff --git a/test/pacman/tests/ldconfig003.py b/test/pacman/tests/ldconfig003.py index 8d1babb..9b2967e 100644 --- a/test/pacman/tests/ldconfig003.py +++ b/test/pacman/tests/ldconfig003.py @@ -6,4 +6,4 @@ self.args = "-S %s" % sp.name self.addrule("PACMAN_RETCODE=0") -self.addrule("FILE_EXIST=/etc/ld.so.cache") +self.addrule("FILE_EXIST=etc/ld.so.cache") diff --git a/test/pacman/tests/sync700.py b/test/pacman/tests/sync700.py index 0002b64..9748c81 100644 --- a/test/pacman/tests/sync700.py +++ b/test/pacman/tests/sync700.py @@ -17,6 +17,6 @@ self.addrule("PACMAN_RETCODE=1") self.addrule("PKG_VERSION=pkg1|1.0-1") -self.addrule("FILE_EXIST=/lib/bar") +self.addrule("FILE_EXIST=lib/bar") self.expectfailure = True -- 1.8.1.1

1 1

[pacman-dev] [GIT] The official pacman repository branch, master, updated. v4.0.3-512-gb27886a
by allan＠archlinux.org 17 Jan '13

17 Jan '13

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "The official pacman repository". The branch, master has been updated via b27886ab5967c30e2e80d46e47968c9f4a95e760 (commit) via 132e1ac10c7fef54372f4d8119b6cc3e82d2c957 (commit) via c628d649f6568fc2627c685add09fc4024e87e4b (commit) via 4a8c2852a887d2b1aaa43be3071ab586eb24b9e3 (commit) via 993700bc6b12cd291544d2a22845f480e8a7925e (commit) via bb4d2b72c1d35ab9d65d632be0dcaf00cfa7d600 (commit) via 60b192e3836a150eb6950ce52241efebbee00f11 (commit) from 9c160cf3f3cbda5fe5b6188e9e31775b71fc5bab (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit b27886ab5967c30e2e80d46e47968c9f4a95e760 Author: William Giokas <1007380(a)gmail.com> Date: Tue Jan 15 22:45:42 2013 -0600 makepkg: Formatting consistency in write_pkginfo The difference between the echo and the printf's in write_pkginfo seemed to be somewhat sporadic. Also, the INFAKEROOT check was doing the same exact thing as the SPLITPKG check, but formatted much differently and consuming two extra lines. I think this makes it more readable than it was previously, if nothing else. Signed-off-by: William Giokas <1007380(a)gmail.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 132e1ac10c7fef54372f4d8119b6cc3e82d2c957 Author: Dave Reisner <dreisner(a)archlinux.org> Date: Tue Jan 15 21:10:04 2013 -0500 dload: avoid showing progress bars on some redirects RFC 2616 doesn't forbid a 301 or 302 repsonse from having a body, and servers exist in the wild that show this behavior. In order to prevent pacman from showing a progress bar when we aren't actually downloading a package (and merely following one of these pain in the butt redirects), capture the server response code in the response header, rather than waiting to peel it off the handle after the download has finished. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Reported-by: Alexandre Filgueira <alexfilgueira(a)cinnarch.com> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit c628d649f6568fc2627c685add09fc4024e87e4b Author: Allan McRae <allan(a)archlinux.org> Date: Fri Jan 11 09:17:24 2013 +1000 Fix release dates Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 4a8c2852a887d2b1aaa43be3071ab586eb24b9e3 Author: Allan McRae <allan(a)archlinux.org> Date: Thu Sep 20 23:09:29 2012 +1000 pmtest: resolve path to scriptlet shell In order to support a variety of values for the --with-scriptlet-shell configure flag, pmtest has to be aware of what kind of path was passed, be it an absolute path or a fragment for a path lookup. For absolute paths, leave the path alone. For fragments, search the PATH environment var for the resolved path to the binary. In both cases, join the resultant path to the root directory defined for the test, not a pre-determined bin directory. Fixes FS#31552. With-contribution-by: Dave Reisner <dreisner(a)archlinux.org> Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 993700bc6b12cd291544d2a22845f480e8a7925e Author: Allan McRae <allan(a)archlinux.org> Date: Mon Jul 16 11:39:58 2012 +1000 Do not require full path for scriptlet shell This increases robustness to the shell location changing paths. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit bb4d2b72c1d35ab9d65d632be0dcaf00cfa7d600 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Jul 16 11:26:31 2012 +1000 Do not use full path for ldconfig The ldconfig binary is not guaranteed to be in /sbin. Change to calling just "ldconfig" rather than using the full path. This removed the check that the ldconfig binary exists. However, it is a reasonable assumption that it will exist if its configuration file does. Signed-off-by: Allan McRae <allan(a)archlinux.org> commit 60b192e3836a150eb6950ce52241efebbee00f11 Author: Allan McRae <allan(a)archlinux.org> Date: Mon Jul 16 11:23:39 2012 +1000 Use execvp for running programs in chroot This makes us more robust to utilities changing paths. There is no functional change when a full path is specified. Signed-off-by: Allan McRae <allan(a)archlinux.org> ----------------------------------------------------------------------- Summary of changes: Makefile.am | 1 + configure.ac | 6 +++--- doc/index.txt | 4 ++-- lib/libalpm/dload.c | 21 ++++++++++++++++----- lib/libalpm/dload.h | 1 + lib/libalpm/util.c | 17 +++++++---------- scripts/makepkg.sh.in | 12 +++++------- test/pacman/pactest.py | 5 +++++ test/pacman/pmenv.py | 2 +- test/pacman/pmtest.py | 21 +++++++++++++++++++-- 10 files changed, 60 insertions(+), 30 deletions(-) hooks/post-receive -- The official pacman repository

1 0

[pacman-dev] [PATCH] [makepkg] Replace `echo`s with `printf`s
by William Giokas 16 Jan '13

16 Jan '13

I was writing up a patch adding in .SRCINFO files, and noticed that the write_pkginfo function had some pretty random uses of echo vs. printf, so I switched them all to printf, including in the help section for the sake of formatting. In write_pkginfo I also re-wrote the fakeroot check to be the same as the splitpkg check. Signed-off-by: William Giokas <1007380(a)gmail.com> --- scripts/makepkg.sh.in | 36 +++++++++++++++++------------------- 1 file changed, 17 insertions(+), 19 deletions(-) diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index c057905..ef85dbe 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -125,7 +125,7 @@ trap_exit() { local signal=$1; shift if (( ! INFAKEROOT )); then - echo + printf "\n" error "$@" fi [[ -n $srclinks ]] && rm -rf "$srclinks" @@ -993,7 +993,7 @@ get_integlist() { local integlist=() for integ in md5 sha1 sha256 sha384 sha512; do - local integrity_sums=($(eval echo "\${${integ}sums[@]}")) + local integrity_sums=($(eval printf "\${${integ}sums[@]}\n")) if [[ -n "$integrity_sums" ]]; then integlist=(${integlist[@]} $integ) fi @@ -1064,10 +1064,10 @@ generate_checksums() { (( ct )) && printf "%s" "$indent" printf "%s" "'$sum'" ct=$(($ct+1)) - (( $ct < $numsrc )) && echo + (( $ct < $numsrc )) && printf "\n" done - echo ")" + printf ")\n" done } @@ -1078,7 +1078,7 @@ check_checksums() { local correlation=0 local integ required for integ in md5 sha1 sha256 sha384 sha512; do - local integrity_sums=($(eval echo "\${${integ}sums[@]}")) + local integrity_sums=($(eval printf "\${${integ}sums[@]}\n")) if (( ${#integrity_sums[@]} == ${#source[@]} )); then msg "$(gettext "Validating source files with %s...")" "${integ}sums" correlation=1 @@ -1091,7 +1091,7 @@ check_checksums() { printf "%s" " $file ... " >&2 if [[ ${integrity_sums[$idx]} = 'SKIP' ]]; then - echo "$(gettext "Skipped")" >&2 + printf "$(gettext "Skipped\n")" >&2 idx=$((idx + 1)) continue fi @@ -1713,14 +1713,12 @@ write_pkginfo() { size="$(( ${size%%[^0-9]*} * 1024 ))" msg2 "$(gettext "Generating %s file...")" ".PKGINFO" - echo "# Generated by makepkg $makepkg_version" - if (( INFAKEROOT )); then - echo "# using $(fakeroot -v)" - fi - echo "# $(LC_ALL=C date -u)" + printf "# Generated by makepkg %s\n" "$makepkg_version" + (( INFAKEROOT )) && printf "# using %S\n" "$(fakeroot -v)" + printf "# %s\n" "$(LC_ALL=C date -u)" printf "pkgname = %s\n" "$pkgname" - (( SPLITPKG )) && echo pkgbase = $pkgbase - echo "pkgver = $(get_full_version)" + (( SPLITPKG )) && printf "pkgbase = %s\n" "$pkgbase" + printf "pkgver = %s\n" "$(get_full_version)" printf "pkgdesc = %s\n" "${pkgdesc//+([[:space:]])/ }" printf "url = %s\n" "$url" printf "builddate = %s\n" "$builddate" @@ -2396,9 +2394,9 @@ m4_include(library/parseopts.sh) usage() { printf "makepkg (pacman) %s\n" "$makepkg_version" - echo + printf "\n" printf -- "$(gettext "Usage: %s [options]")\n" "$0" - echo + printf "\n" printf -- "$(gettext "Options:")\n" printf -- "$(gettext " -A, --ignorearch Ignore incomplete %s field in %s")\n" "arch" "$BUILDSCRIPT" printf -- "$(gettext " -c, --clean Clean up work files after build")\n" @@ -2429,16 +2427,16 @@ usage() { printf -- "$(gettext " --skipchecksums Do not verify checksums of the source files")\n" printf -- "$(gettext " --skipinteg Do not perform any verification checks on source files")\n" printf -- "$(gettext " --skippgpcheck Do not verify source files with PGP signatures")\n" - echo + printf "\n" printf -- "$(gettext "These options can be passed to %s:")\n" "pacman" - echo + printf "\n" printf -- "$(gettext " --asdeps Install packages as non-explicitly installed")\n" printf -- "$(gettext " --noconfirm Do not ask for confirmation when resolving dependencies")\n" printf -- "$(gettext " --needed Do not reinstall the targets that are already up to date")\n" printf -- "$(gettext " --noprogressbar Do not show a progress bar when downloading files")\n" - echo + printf "\n" printf -- "$(gettext "If %s is not specified, %s will look for '%s'")\n" "-p" "makepkg" "$BUILDSCRIPT" - echo + printf "\n" } version() { -- 1.8.1.336.g94702dd

2 2

[pacman-dev] [PATCH] dload: avoid showing progress bars on some redirects
by Dave Reisner 16 Jan '13

16 Jan '13

RFC 2616 doesn't forbid a 301 or 302 repsonse from having a body, and servers exist in the wild that show this behavior. In order to prevent pacman from showing a progress bar when we aren't actually downloading a package (and merely following one of these pain in the butt redirects), capture the server response code in the response header, rather than waiting to peel it off the handle after the download has finished. Signed-off-by: Dave Reisner <dreisner(a)archlinux.org> Reported-by: Alexandre Filgueira <alexfilgueira(a)cinnarch.com> --- lib/libalpm/dload.c | 21 ++++++++++++++++----- lib/libalpm/dload.h | 1 + 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/lib/libalpm/dload.c b/lib/libalpm/dload.c index ee19adb..83d2051 100644 --- a/lib/libalpm/dload.c +++ b/lib/libalpm/dload.c @@ -96,6 +96,11 @@ static int dload_progress_cb(void *file, double dltotal, double dlnow, struct dload_payload *payload = (struct dload_payload *)file; off_t current_size, total_size; + /* avoid displaying progress bar for redirects with a body */ + if(payload->respcode >= 300) { + return 0; + } + /* SIGINT sent, abort by alerting curl */ if(dload_interrupted) { return 1; @@ -199,6 +204,7 @@ static size_t dload_parseheader_cb(void *ptr, size_t size, size_t nmemb, void *u const char * const cd_header = "Content-Disposition:"; const char * const fn_key = "filename="; struct dload_payload *payload = (struct dload_payload *)user; + long respcode; if(_alpm_raw_ncmp(cd_header, ptr, strlen(cd_header)) == 0) { if((fptr = strstr(ptr, fn_key))) { @@ -220,6 +226,11 @@ static size_t dload_parseheader_cb(void *ptr, size_t size, size_t nmemb, void *u } } + curl_easy_getinfo(payload->handle->curl, CURLINFO_RESPONSE_CODE, &respcode); + if(payload->respcode != respcode) { + payload->respcode = respcode; + } + return realsize; } @@ -383,7 +394,7 @@ static int curl_download_internal(struct dload_payload *payload, char hostname[HOSTNAME_SIZE]; char error_buffer[CURL_ERROR_SIZE] = {0}; struct stat st; - long timecond, respcode = 0, remote_time = -1; + long timecond, remote_time = -1; double remote_size, bytes_dl; struct sigaction orig_sig_pipe, orig_sig_int; /* shortcut to our handle within the payload */ @@ -463,13 +474,12 @@ static int curl_download_internal(struct dload_payload *payload, switch(payload->curlerr) { case CURLE_OK: /* get http/ftp response code */ - curl_easy_getinfo(curl, CURLINFO_RESPONSE_CODE, &respcode); - _alpm_log(handle, ALPM_LOG_DEBUG, "response code: %ld\n", respcode); - if(respcode >= 400) { + _alpm_log(handle, ALPM_LOG_DEBUG, "response code: %ld\n", payload->respcode); + if(payload->respcode >= 400) { payload->unlink_on_fail = 1; /* non-translated message is same as libcurl */ snprintf(error_buffer, sizeof(error_buffer), - "The requested URL returned error: %ld", respcode); + "The requested URL returned error: %ld", payload->respcode); _alpm_log(handle, ALPM_LOG_ERROR, _("failed retrieving file '%s' from %s : %s\n"), payload->remote_name, hostname, error_buffer); @@ -725,6 +735,7 @@ void _alpm_dload_payload_reset(struct dload_payload *payload) FREE(payload->destfile_name); FREE(payload->content_disp_name); FREE(payload->fileurl); + memset(payload, '\0', sizeof(*payload)); } /* vim: set ts=2 sw=2 noet: */ diff --git a/lib/libalpm/dload.h b/lib/libalpm/dload.h index ca17200..70e3479 100644 --- a/lib/libalpm/dload.h +++ b/lib/libalpm/dload.h @@ -42,6 +42,7 @@ struct dload_payload { #ifdef HAVE_LIBCURL CURLcode curlerr; /* last error produced by curl */ #endif + long respcode; }; void _alpm_dload_payload_reset(struct dload_payload *payload); -- 1.8.1.1

1 0

[pacman-dev] [PATCH] add the ability to only build on new pkgver or pkgrel
by Daniel Wallace 16 Jan '13

16 Jan '13

If I haven't bumped the pkgrel, or there have been no new commits, I don't want to rebuild the package. Similar to the --needed flag, but pertains to building instead of installing. --- contrib/bash_completion.in | 4 ++-- contrib/zsh_completion.in | 1 + doc/makepkg.8.txt | 4 ++++ scripts/makepkg.sh.in | 10 +++++++++- 4 files changed, 16 insertions(+), 3 deletions(-) diff --git a/contrib/bash_completion.in b/contrib/bash_completion.in index b0901af..af382e8 100644 --- a/contrib/bash_completion.in +++ b/contrib/bash_completion.in @@ -74,8 +74,8 @@ _makepkg() { COMPREPLY=() _get_comp_words_by_ref cur prev if [[ $cur = -* && ! $prev =~ ^-(-(config|help)$|\w*[Chp]) ]]; then - opts=('allsource asdeps asroot check clean config force geninteg help holdver ignorearch - install log nobuild nocheck nocolor noconfirm nodeps noextract + opts=('allsource asdeps asroot buildneeded check clean config force geninteg help holdver + ignorearch install log nobuild nocheck nocolor noconfirm nodeps noextract noprogressbar nosign pkg repackage rmdeps sign skipinteg source syncdeps' 'A L R S c d e f g h i m o p r s') _arch_ptr2comp opts diff --git a/contrib/zsh_completion.in b/contrib/zsh_completion.in index 84ee93c..342803f 100644 --- a/contrib/zsh_completion.in +++ b/contrib/zsh_completion.in @@ -457,6 +457,7 @@ _makepkg_longopts=( '--ignorearch[Ignore incomplete arch field in PKGBUILD]' '--clean[Clean up work files after build]' '--nodeps[Skip all dependency checks]' + '--buildneeded[Skip building if the same version is already installed]' '--noextract[Do not extract source files (use existing src/ dir)]' '--force[Overwrite existing package]' '--geninteg[Generate integrity checks for source files]' diff --git a/doc/makepkg.8.txt b/doc/makepkg.8.txt index 498c79b..d45a703 100644 --- a/doc/makepkg.8.txt +++ b/doc/makepkg.8.txt @@ -58,6 +58,10 @@ Options will break the build process if all of the dependencies are not installed. +*\--buildneeded*:: + Do not build if the installed version and the version in the build script + are the same. + *-e, \--noextract*:: Do not extract source files or run the prepare() function (if present); use whatever source already exists in the $srcdir/ directory. This is diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index ebc24f7..c267e56 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -65,6 +65,7 @@ SKIPCHECKSUMS=0 SKIPPGPCHECK=0 INSTALL=0 NOBUILD=0 +ONLYNEWPKGVER=0 NODEPS=0 NOEXTRACT=0 RMDEPS=0 @@ -707,6 +708,12 @@ update_pkgver() { "$BUILDFILE" fi fi + if (( ONLYNEWPKGVER )); then + if run_pacman -T "$pkgname=$pkgver-$pkgrel" 2>/dev/null; then + msg "$(gettext "Skipping -- $pkgname-$pkgver-$pkgrel is already installed")" + exit 0 + fi + fi } # Print 'source not found' error message and exit makepkg @@ -2460,7 +2467,7 @@ ARGLIST=("$@") # Parse Command Line Options. OPT_SHORT="AcdefFghiLmop:rRsSV" -OPT_LONG=('allsource' 'asroot' 'check' 'clean' 'config:' 'force' 'geninteg' +OPT_LONG=('allsource' 'asroot' 'onlynewpkgver' 'check' 'clean' 'config:' 'force' 'geninteg' 'help' 'holdver' 'ignorearch' 'install' 'key:' 'log' 'nobuild' 'nocolor' 'nocheck' 'nodeps' 'noextract' 'nosign' 'pkg:' 'repackage' 'rmdeps' 'skipchecksums' 'skipinteg' 'skippgpcheck' 'skippgpcheck' 'sign' @@ -2503,6 +2510,7 @@ while true; do --nocheck) RUN_CHECK='n' ;; --nosign) SIGNPKG='n' ;; -o|--nobuild) NOBUILD=1 ;; + --buildneeded) ONLYNEWPKGVER=1 ;; -p) shift; BUILDFILE=$1 ;; --pkg) shift; IFS=, read -ra p <<<"$1"; PKGLIST+=("${p[@]}"); unset p ;; -r|--rmdeps) RMDEPS=1 ;; -- 1.8.1.1

2 1

[pacman-dev] Minor issues in lib/libalpm/dload.c
by LANGLOIS Olivier PIS -EXT 15 Jan '13

15 Jan '13

Hi, The following 2 lines has caused me some problems: curl_easy_setopt(curl, CURLOPT_LOW_SPEED_LIMIT, 1024L); curl_easy_setopt(curl, CURLOPT_LOW_SPEED_TIME, 10L); When I bring my laptop at job, I find myself behind a weird corporate router/firewall that throttle down the speed to ~ 1B/sec for the first 10 seconds possibly to reduce bandwidth usage (my personal explanation. People have time to cancel unwanted downloads). This was making my pacman fail to sync any DB. It was just jumping from 1 mirror to another. To fix my problem, I just removed the 2 problematic 2 lines and now everything works like a charm. I share my problem here because I understand that these lines are used to switch to a better mirror in case poor download are caused by the server. I am wondering if I am the only and first user having this problem and how it could be solved cleanly for everyone upstream. Making the option values configurable ? deactivable? ________________________________ CONFIDENTIALITY : This e-mail and any attachments are confidential and may be privileged. If you are not a named recipient, please notify the sender immediately and do not disclose the contents to another person, use it for any purpose or store or copy the information in any medium.

2 2

[pacman-dev] [PATCH] Not trigger twice progressbar on some redirections
by Alexandre Filgueira 11 Jan '13

11 Jan '13

I found that pacman was triggerin the progressbar callback twice when pointing to my repo, which uses Mirrorbrain to geolocate the closest mirror. After asking here in this list and in the curl library list, the thing was that my header redirection response had a body, so curl was triggering twice, downloading first just bytes (of the redirection) and then the proper file. I changed the dload.c code to avoid this, I don't know if it is correct to do it the way I did. Now is triggering just once. This is my modifications: --- dload_original.c 2013-01-11 10:48:21.751443000 +0100 +++ dload_new.c 2013-01-11 10:44:13.049630000 +0100 @@ -95,6 +95,8 @@ { struct dload_payload *payload = (struct dload_payload *)file; off_t current_size, total_size; + alpm_handle_t *handle = payload->handle; + CURL *curl = get_libcurl_handle(handle); /* SIGINT sent, abort by alerting curl */ if(dload_interrupted) { @@ -103,6 +105,13 @@ current_size = payload->initial_size + (off_t)dlnow; + /* not show progressbar when redirection has body*/ + long respcode = 0; + curl_easy_getinfo (curl, CURLINFO_RESPONSE_CODE, &respcode); + if (respcode == 302 && current_size > 0) { + return 0; + } + /* is our filesize still under any set limit? */ if(payload->max_size && current_size > payload->max_size) { dload_interrupted = ABORT_OVER_MAXFILESIZE;

3 3

[pacman-dev] [PATCH] Fix release dates
by Allan McRae 10 Jan '13

10 Jan '13

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- doc/index.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/index.txt b/doc/index.txt index 3d346b8..a7a82d4 100644 --- a/doc/index.txt +++ b/doc/index.txt @@ -71,8 +71,8 @@ Releases [frame="topbot",grid="none",options="header,autowidth"] !====== !Version !Date -!4.0.3 !2011-04-07 -!4.0.2 !2011-02-11 +!4.0.3 !2012-04-07 +!4.0.2 !2012-02-11 !4.0.1 !2011-11-20 !4.0.0 !2011-10-13 !4.0.0rc2 !2011-09-22 -- 1.8.1

1 0