December 2014 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] Fix pointer declarations to be globally consistent
by Micah Saint Germain 15 Dec '14

15 Dec '14

From: Micah Saint Germain <micahsg(a)google.com> Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micahsg(a)google.com> --- src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event); /* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question); /* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation"); /* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) } if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0

4 3

[pacman-dev] [PATCH] Fix pointer declarations to be globally consistent
by micah＠lexme.org 15 Dec '14

15 Dec '14

From: Micah Saint Germain <micah(a)lexme.org> Refactored inconsistent pointer declarations to better improve consistency throughout the pacman codebase which will, in turn, increase readability to the user. Expected format of a pointer declaration: `typename *varname` Signed-off-by: Micah Saint Germain <micah(a)lexme.org> --- src/pacman/callback.h | 2 +- src/pacman/pacman.c | 10 +++++----- src/pacman/sync.c | 2 +- src/util/pactree.c | 2 +- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/pacman/callback.h b/src/pacman/callback.h index 5480c73..498536f 100644 --- a/src/pacman/callback.h +++ b/src/pacman/callback.h @@ -28,7 +28,7 @@ void cb_event(alpm_event_t *event); /* callback to handle questions from libalpm (yes/no) */ -void cb_question(alpm_question_t* question); +void cb_question(alpm_question_t *question); /* callback to handle display of progress */ void cb_progress(alpm_progress_t event, const char *pkgname, int percent, diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..f43105a 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -97,11 +97,11 @@ static void usage(int op, const char * const myname) alpm_list_t *list = NULL, *i; /* prefetch some strings for usage below, which moves a lot of calls * out of gettext. */ - char const * const str_opt = _("options"); - char const * const str_file = _("file(s)"); - char const * const str_pkg = _("package(s)"); - char const * const str_usg = _("usage"); - char const * const str_opr = _("operation"); + char const *const str_opt = _("options"); + char const *const str_file = _("file(s)"); + char const *const str_pkg = _("package(s)"); + char const *const str_usg = _("usage"); + char const *const str_opr = _("operation"); /* please limit your strings to 80 characters in width */ if(op == PM_OP_MAIN) { diff --git a/src/pacman/sync.c b/src/pacman/sync.c index 4609186..215497f 100644 --- a/src/pacman/sync.c +++ b/src/pacman/sync.c @@ -230,7 +230,7 @@ static int sync_cleancache(int level) } if(level <= 1) { - static const char * const glob_skips[] = { + static const char *const glob_skips[] = { /* skip signature files - they are removed with their package file */ "*.sig", /* skip package database within the cache directory */ diff --git a/src/util/pactree.c b/src/util/pactree.c index 5c76542..14579e4 100644 --- a/src/util/pactree.c +++ b/src/util/pactree.c @@ -339,7 +339,7 @@ static void cleanup(void) static void print_text(const char *pkg, const char *provision, tdepth *depth, int last) { - const char* tip = ""; + const char *tip = ""; int level = 1; if(!pkg && !provision) { /* not much we can do */ -- 2.1.0

1 0

[pacman-dev] [PATCH 1/2] shut up GCC on -Wmaybe-initialized warnings
by Dave Reisner 15 Dec '14

15 Dec '14

Admittedly, these are totally bogus, but a clean build is a happy build. --- src/pacman/conf.c | 2 +- src/pacman/pacman.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/src/pacman/conf.c b/src/pacman/conf.c index 5028284..873ca0e 100644 --- a/src/pacman/conf.c +++ b/src/pacman/conf.c @@ -459,7 +459,7 @@ static int process_cleanmethods(alpm_list_t *values, static void setrepeatingoption(char *ptr, const char *option, alpm_list_t **list) { - char *val, *saveptr; + char *val, *saveptr = NULL; val = strtok_r(ptr, " ", &saveptr); while(val) { diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 6161048..6234570 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -341,8 +341,7 @@ static void invalid_opt(int used, const char *opt1, const char *opt2) static int parsearg_util_addlist(alpm_list_t **list) { - char *i, *save; - + char *i, *save = NULL; for(i = strtok_r(optarg, ",", &save); i; i = strtok_r(NULL, ",", &save)) { *list = alpm_list_add(*list, strdup(i)); -- 2.1.3

3 3

[pacman-dev] [PATCH] updpkgsums: drop in-place rewrite hack, use a tempfile
by Dave Reisner 14 Dec '14

14 Dec '14

This apparently exposes (what I think is) a subtle bug in cygwin's handling of subst'd drives. Let's just drop the hackery and use a tempfile, which should always work. Also, introduce a proper die() function which replaces previous hand-rolled error+exit pattern, but which wrote to stdout. --- contrib/updpkgsums.sh.in | 37 +++++++++++++++++++++++-------------- 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/contrib/updpkgsums.sh.in b/contrib/updpkgsums.sh.in index e0524bd..a40845b 100644 --- a/contrib/updpkgsums.sh.in +++ b/contrib/updpkgsums.sh.in @@ -40,6 +40,11 @@ version() { echo 'Copyright (C) 2012-2013 Dave Reisner <dreisner(a)archlinux.org>' } +die() { + printf "==> ERROR: $1\n" "${@:2}" >&2 + exit 1 +} + case $1 in -h|--help) usage; exit ;; -V|--version) version; exit ;; @@ -47,8 +52,7 @@ esac buildfile=${1:-PKGBUILD} if [[ ! -f $buildfile ]]; then - printf "==> ERROR: %s not found or is not a file\n" "$buildfile" - exit 1 + die "%s not found or is not a file" "$buildfile" fi # Resolve any symlinks to avoid replacing the symlink with a file. But, we @@ -71,18 +75,19 @@ fi # Check $PWD/ for permission to unlink the $buildfile and write a new one if [[ ! -w . ]]; then - printf "==> ERROR: No write permission in '%s'\n" "$PWD" - exit 1 + die "No write permission in '%s'" "$PWD" fi -{ - # Generate the new sums and try to unlink the file before writing stdin back - # into it. This final precaution shouldn't fail based on the previous checks, - # but it's better to be extra careful before unlinking files. - export BUILDDIR=$(mktemp -d --tmpdir updpkgsums.XXXXXX) - trap "rm -rf '$BUILDDIR'" EXIT - newsums=$(makepkg -g -p "$buildfile") && rm -f "$buildfile" && - awk -v newsums="$newsums" ' +# Generate the new sums +export BUILDDIR=$(mktemp -d --tmpdir updpkgsums.XXXXXX) +newbuildfile=$(mktemp --tmpdir updpkgsums.XXXXXX) + +# In case the eventual replacement fails, we don't want to leave behind +# $newbuildfile as garbage in $TMPDIR. This fails silently if the replacement +# succeeds. +trap "rm -rf '$BUILDDIR' '$newbuildfile'" EXIT +newsums=$(makepkg -g -p "$buildfile") && +awk -v newsums="$newsums" ' /^[[:blank:]]*(md|sha)[[:digit:]]+sums(_[^=]+)?=/,/\)[[:blank:]]*(#.*)?$/ { if (!w) { print newsums @@ -93,7 +98,11 @@ fi 1 END { if (!w) print newsums } - ' > "$buildfile" -} < "$buildfile" +' "$buildfile" > "$newbuildfile" + +# Replace the original buildfile. +if ! mv -- "$newbuildfile" "$buildfile"; then + die "Failed to update %s. The file has not been modified." "$buildfile" +fi # vim: set noet: -- 2.1.3

1 0

[pacman-dev] updpkgsums read/write collision
by David Macek 14 Dec '14

14 Dec '14

Hi all. I have noticed a problem with updpkgsums on Windows when it's run on a subst'd drive (created with `subst` or using an entry in `DOS Devices` registry key). The error message I see is following: /usr/bin/updpkgsums: line 85: PKGBUILD: Permission denied The PKGBUILD is then gone. I don't fully understand what's going on on lines 78-97 with the input/output redirection and deleting, but I assume this can be fixed by 1) either enhancing the routine for dereferencing symlinks (lines 54-62) to recognize subst'd drives, 2) or by modifying the script to first rename the original $buildfile, and delete it after finishing the new $buildfile. For the time being, I worked around the problem by modifying the script to first read $buildfile into a variable, then delete it and then pass the variable contents to awk to write to $buildfile. My question is following: can the script be changed in order to avoid this issue? Ref: https://github.com/Alexpux/MSYS2-packages/issues/143 -- David Macek

2 4

[pacman-dev] Anyone want to update NEWS and README files?
by Allan McRae 08 Dec '14

08 Dec '14

The last thing for the 4.1 release is to updated the NEWS and README files. The README file is updated by looking at "git diff v4.1.0 lib/libalpm/alpm.h" and noting the changes. NEWS is updated by scrolling through the commits/bugtracker and looking for points of interest. I doubt I can get to this before the weekend, so if someone else does this, the release can be made! Cheers, Allan

1 0