December 2015 - Pacman-dev - lists.archlinux.org

[pacman-dev] [PATCH] Added the --bell switch.
by Eric Toombs 26 Jun '16

26 Jun '16

This switch rings the terminal bell when user input is required. Obviously, it has no effect if --noconfirm is also passed. --- doc/pacman.8.txt | 3 +++ src/pacman/conf.h | 4 +++- src/pacman/pacman.c | 3 +++ src/pacman/util.c | 15 +++++++++------ 4 files changed, 18 insertions(+), 7 deletions(-) diff --git a/doc/pacman.8.txt b/doc/pacman.8.txt index 514f559..6e0617a 100644 --- a/doc/pacman.8.txt +++ b/doc/pacman.8.txt @@ -148,6 +148,9 @@ Options *\--arch* <arch>:: Specify an alternate architecture. +*\--bell*:: + Sound the terminal bell when input is required. + *\--cachedir* <dir>:: Specify an alternative package cache location (a typical default is +{localstatedir}/cache/pacman/pkg+). Multiple cache directories can be diff --git a/src/pacman/conf.h b/src/pacman/conf.h index 7a7e9cf..463ae48 100644 --- a/src/pacman/conf.h +++ b/src/pacman/conf.h @@ -55,6 +55,7 @@ typedef struct __config_t { unsigned short checkspace; unsigned short usesyslog; unsigned short color; + unsigned short bell; double deltaratio; char *arch; char *print_format; @@ -201,7 +202,8 @@ enum { OP_VERBOSE, OP_DOWNLOADONLY, OP_REFRESH, - OP_ASSUMEINSTALLED + OP_ASSUMEINSTALLED, + OP_BELL }; /* clean method */ diff --git a/src/pacman/pacman.c b/src/pacman/pacman.c index 94685a7..07282e7 100644 --- a/src/pacman/pacman.c +++ b/src/pacman/pacman.c @@ -221,6 +221,7 @@ static void usage(int op, const char * const myname) addlist(_(" --logfile <path> set an alternate log file\n")); addlist(_(" --noconfirm do not ask for any confirmation\n")); addlist(_(" --confirm always ask for confirmation\n")); + addlist(_(" --bell sound the terminal bell when input is required\n")); } list = alpm_list_msort(list, alpm_list_count(list), options_cmp); for(i = list; i; i = alpm_list_next(i)) { @@ -480,6 +481,7 @@ static int parsearg_global(int opt) case OP_CONFIRM: config->noconfirm = 0; break; + case OP_BELL: config->bell = 1; break; case OP_DBPATH: case 'b': free(config->dbpath); @@ -981,6 +983,7 @@ static int parseargs(int argc, char *argv[]) {"gpgdir", required_argument, 0, OP_GPGDIR}, {"dbonly", no_argument, 0, OP_DBONLY}, {"color", required_argument, 0, OP_COLOR}, + {"bell", no_argument, 0, OP_BELL}, {0, 0, 0, 0} }; diff --git a/src/pacman/util.c b/src/pacman/util.c index 5f331e8..9183047 100644 --- a/src/pacman/util.c +++ b/src/pacman/util.c @@ -1396,13 +1396,14 @@ int multiselect_question(char *array, int count) fprintf(stream, "\n"); fprintf(stream, _("Enter a selection (default=all)")); fprintf(stream, ": "); - fflush(stream); if(config->noconfirm) { fprintf(stream, "\n"); break; + } else if(config->bell) { + fprintf(stream, "\a"); } - + fflush(stream); flush_term_input(fileno(stdin)); if(safe_fgets(response, response_len, stdin)) { @@ -1463,13 +1464,14 @@ int select_question(int count) fprintf(stream, "\n"); fprintf(stream, _("Enter a number (default=%d)"), preset); fprintf(stream, ": "); - fflush(stream); if(config->noconfirm) { fprintf(stream, "\n"); break; + } else if(config->bell) { + fprintf(stream, "\a"); } - + fflush(stream); flush_term_input(fileno(stdin)); if(safe_fgets(response, sizeof(response), stdin)) { @@ -1517,13 +1519,14 @@ static int question(short preset, const char *format, va_list args) } fputs(config->colstr.nocolor, stream); - fflush(stream); if(config->noconfirm) { fprintf(stream, "\n"); return preset; + } else if(config->bell) { + fprintf(stream, "\a"); } - + fflush(stream); flush_term_input(fd_in); if(safe_fgets(response, sizeof(response), stdin)) { -- 2.6.2

3 8

[pacman-dev] Please make the colourised output exactly like that of "pacman-color"
by Xavion 29 Apr '16

29 Apr '16

Hi All, It's great that "pacman" finally has native colour support in v4.1.0. It's just a shame that it's not as good as that of "pacman-color". Without meaning any offence, it falls way short of the mark IMHO. I'm hoping you can just replicate the colourisation of "pacman-color". For your convenience, I've attached the relevant files you'd need. I'm only requesting this because "pacman-color" no longer exists. -- Regards, Xavion.

10 60

[pacman-dev] [PATCH] test version range restrictions corner case
by Dominik Fischer 19 Feb '16

19 Feb '16

The test introduced herein illustrates a behavior that may be unexpected to package writers. It creates a package "pkg3" that is configured to depend on a "dependency" which version is between 3 and 4, inclusive. Two other packages are already present, providing "dependency" in version 2 and 5, respectively. So, the situation looks roughly like this: pkg1 pkg3 pkg2 provides depends on provides | <------------> | version __________2____________3____________4____________5___________... This seems to be enough to satisfy pacman when installing "pkg3". From an iterative standpoint, this is completely logical: First, the requirement "dependency>=3" is checked. There is a package that satisfies this restriction, it is called "pkg2". Afterwards, "dependency<=4" is covered in the same way by "pkg1". Nonetheless, what a package writer intends when specifying depends=('dependency>=3' 'dependency<=4') is most probably that pacman should only allow this package to be installed when there indeed is a package present that provides a version of "dependency" that lies _between_ 3 and 5. Signed-off-by: Dominik Fischer <d dot f dot fischer at web dot de> --- This behavior may be intended though. If so, this corner case should perhaps be noted in the documentation. Please review and comment. test/pacman/tests/TESTS | 1 + test/pacman/tests/deprange001.py | 17 +++++++++++++++++ 2 files changed, 18 insertions(+) create mode 100644 test/pacman/tests/deprange001.py diff --git a/test/pacman/tests/TESTS b/test/pacman/tests/TESTS index bee7c8e..f35ec1a 100644 --- a/test/pacman/tests/TESTS +++ b/test/pacman/tests/TESTS @@ -15,6 +15,7 @@ TESTS += test/pacman/tests/depconflict110.py TESTS += test/pacman/tests/depconflict111.py TESTS += test/pacman/tests/depconflict120.py TESTS += test/pacman/tests/dependency-cycle-fixed-by-upgrade.py +TESTS += test/pacman/tests/deprange001.py TESTS += test/pacman/tests/deptest001.py TESTS += test/pacman/tests/dummy001.py TESTS += test/pacman/tests/epoch001.py diff --git a/test/pacman/tests/deprange001.py b/test/pacman/tests/deprange001.py new file mode 100644 index 0000000..bab52fa --- /dev/null +++ b/test/pacman/tests/deprange001.py @@ -0,0 +1,17 @@ +self.description = "undetected conflict with version range" + +lp1 = pmpkg("pkg1") +lp1.provides = ["dependency=2"] +self.addpkg2db("local", lp1) + +lp2 = pmpkg("pkg2") +lp2.provides = ["dependency=5"] +self.addpkg2db("local", lp2) + +p = pmpkg("pkg3") +p.depends = ["dependency>3", "dependency<4"] +self.addpkg(p) + +self.args = "-U %s" % p.filename() +self.addrule("PACMAN_RETCODE=1") +self.addrule("!PKG_EXIST=pkg3") -- 2.6.3

4 8

[pacman-dev] [PATCH] zsh_completion: add -q/--quiet for -Q/-S
by genml+pacman-dev＠thequod.de 26 Jan '16

26 Jan '16

From: Daniel Hahler <git(a)thequod.de> This should also be added for "-Fh", but that is missing completely in zsh_completion. 1: https://lists.archlinux.org/pipermail/pacman-dev/2015-November/020538.html Signed-off-by: Daniel Hahler <git(a)thequod.de> --- contrib/zsh_completion.in | 2 ++ 1 file changed, 2 insertions(+) diff --git a/contrib/zsh_completion.in b/contrib/zsh_completion.in index 0db26b2..58d409a 100644 --- a/contrib/zsh_completion.in +++ b/contrib/zsh_completion.in @@ -65,6 +65,7 @@ _pacman_opts_query_modifiers=( {-l,--list}'[List package contents]' {-m,--foreign}'[List installed packages not found in sync db(s)]' {-n,--native}'[List installed packages found in sync db(s)]' + {-q,--quiet}'[Show less information for query and search]' {-t,--unrequired}'[List packages not required by any package]' {-u,--upgrades}'[List packages that can be upgraded]' ) @@ -104,6 +105,7 @@ _pacman_opts_sync_modifiers=( {\*-i,\*--info}'[View package information]' {-l,--list}'[List all packages in a repository]' {-p,--print}'[Print download URIs for each package to be installed]' + {-q,--quiet}'[Show less information for query and search]' {\*-u,\*--sysupgrade}'[Upgrade all out-of-date packages]' {-w,--downloadonly}'[Download packages only]' {\*-y,\*--refresh}'[Download fresh package databases]' -- 2.6.4

3 3

[pacman-dev] Clang warnings
by Rikard Falkeborn 15 Jan '16

15 Jan '16

There are some warnings recently introduced when compiling with Clang (with --enable-warningflags) for x86_64. The warnings are related to casting of specific alpm_event-types to alpm_event_t where the required alignment differs between the types. On x86, it shouldn't be a problem, but maybe there are other architectures pacman should work on where this is a real issue? Either way, I think it would be good if pacman built cleanly with Clang. Any suggestions on how to fix this? For reference, the warnings are: hook.c:732:3: warning: cast from 'alpm_event_hook_t *' (aka 'struct _alpm_event_hook_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~ hook.c:761:3: warning: cast from 'alpm_event_hook_t *' (aka 'struct _alpm_event_hook_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~ 2 warnings generated. trans.c:202:2: warning: cast from 'alpm_event_any_t *' (aka 'struct _alpm_event_any_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~ trans.c:226:3: warning: cast from 'alpm_event_any_t *' (aka 'struct _alpm_event_any_t *') to 'alpm_event_t *' (aka 'union _alpm_event_t *') increases required alignment from 4 to 8 [-Wcast-align] EVENT(handle, &event); ^~~~~~~~~~~~~~~~~~~~~ ./handle.h:37:16: note: expanded from macro 'EVENT' (h)->eventcb((alpm_event_t *) (e)); \ ^~~~~~~~~~~~~~~~~~~~

4 12

[pacman-dev] [PATCH] libalpm, fix leak if malloc fails in be_sync
by Rikard Falkeborn 04 Jan '16

04 Jan '16

--- lib/libalpm/be_sync.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/libalpm/be_sync.c b/lib/libalpm/be_sync.c index b09b060..9229622 100644 --- a/lib/libalpm/be_sync.c +++ b/lib/libalpm/be_sync.c @@ -178,6 +178,7 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) const char *dbext; alpm_list_t *i; int ret = -1; + int memory_error = 0; mode_t oldmask; alpm_handle_t *handle; alpm_siglevel_t level; @@ -230,8 +231,7 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) /* print server + filename into a buffer */ len = strlen(server) + strlen(db->treename) + strlen(dbext) + 2; - /* TODO fix leak syncpath and umask unset */ - MALLOC(payload.fileurl, len, RET_ERR(handle, ALPM_ERR_MEMORY, -1)); + MALLOC(payload.fileurl, len, memory_error = 1; goto cleanup); snprintf(payload.fileurl, len, "%s/%s%s", server, db->treename, dbext); payload.handle = handle; payload.force = force; @@ -269,8 +269,7 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) len = strlen(server) + strlen(db->treename) + strlen(dbext) + 6; } - /* TODO fix leak syncpath and umask unset */ - MALLOC(payload.fileurl, len, RET_ERR(handle, ALPM_ERR_MEMORY, -1)); + MALLOC(payload.fileurl, len, memory_error = 1; goto cleanup); if(final_db_url != NULL) { snprintf(payload.fileurl, len, "%s.sig", final_db_url); @@ -322,9 +321,10 @@ int SYMEXPORT alpm_db_update(int force, alpm_db_t *db) } cleanup: - _alpm_handle_unlock(handle); free(syncpath); umask(oldmask); + ASSERT(memory_error == 0, RET_ERR(handle, ALPM_ERR_MEMORY, -1)); + _alpm_handle_unlock(handle); return ret; } -- 2.6.2

3 2

[pacman-dev] [PATCH 0/3] Char signedness issues
by Rikard Falkeborn 04 Jan '16

04 Jan '16

I tried compiling pacman on my RPi (Arm), where char is unsigned by default. That leads to some things not working the way they are expected too. The problem is as follows: char a = -1; if (a == -1) { ... } If char is unsigned, we will not enter the if-statement (a is converted to int) before making the comparisson. Gcc will warn about these comparissons. The first two patches fixes the cases I (and Gcc) could find, and the third one is a couple of tests I wrote to convince myself there was a problem in pacsort (and more importantly, that the changes actually fixes something). After doing this, I realize that the simplest solution probably would be to add -fsigned-char as an argument to the compiler... thoughts? Rikard Falkeborn (3): Make alpm_graph state signedness explicit pacsort, introduce define for escape_char error code Add pacsort tests with invalid input lib/libalpm/graph.h | 2 +- src/util/pacsort.c | 11 ++++++----- test/util/pacsorttest.sh | 18 +++++++++++++++++- 3 files changed, 24 insertions(+), 7 deletions(-) -- 2.6.4

2 5

[pacman-dev] [PATCH] Update NEWS for pacman-5.0
by Allan McRae 01 Jan '16

01 Jan '16

Signed-off-by: Allan McRae <allan(a)archlinux.org> --- NEWS | 65 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 63 insertions(+), 2 deletions(-) diff --git a/NEWS b/NEWS index a4d3dba..e2ae89b 100644 --- a/NEWS +++ b/NEWS @@ -1,8 +1,69 @@ VERSION DESCRIPTION ----------------------------------------------------------------------------- -5.0.0 - pacman can check the validity of the local and sync databases +5.0.0 - pacman can run hooks pre- and post-transaction. See the + alpm-hooks(5) man page for details and an example hook (FS#2985) + - pacman can now sync and read .files databases (-Fy) and do basic + searching for files in sync repos (-Fs, -Fo) (FS#23787) + - pacman can check the validity of the local and sync databases (-Dk and -Dkk respectively). This replaces the 'testdb' - software + software (FS#42444) + - the package description output (-Si ,-Qi) is now correctly + aligned regardless of locale (FS#43983, FS#45997) + - ensure internal package version matches database version after + downloading (FS#45687) + - improved signal handling and lock file removal (FS#45995, + FS#46375, FS#47011) + - print more information when encountering dependency errors + - fix conflict with CheckSpace and NoExtract (FS#47470) + - improved configuration parsing with a new ini parser + - handle a symlink to a directory being replaced by a directory + - The 'pkgbase' variable is now recorded in the local package db + - Remove support for ".pacorig" files. Instead, packages files + are extracted as a ".pacnew" and the original stays in place + - prevent install scriptlets using stdin for user interaction + - provides are considered when displaying optdepends install + status (FS#36412) + - always update corrupt database whether or not a newer version + is found on the remote server + - fix build issues when libarchive was in a non-standard location + - Many issues found using Coverity were address (primarily freeing + memory on error conditions) + - The pactest suite was upgraded to allow parallel testing using + the tap.sh library + - makepkg: + - makepkg is in the process of being split into a library. This + allows various areas to be extended by adding a file into + libmakepkg (e.g. package/PKGBUILD checking, adjusting + files before creating the final package). + - PKGBUILD variables checked to be arrays or not as appropriate + - pkgver() and prepare() are now run with --noextract (FS#43498, + FS#46800) + - the ability to build a single package in a PKGBUILD has been + removed + - the output when checking checksums for architecture specific + sources is improved (FS#43444) + - improved handling of bazaar sources (FS#43448) + - fix source package signing with SRCPKGDIR set + - add option to compress png images with optipng + - add --packagelist option, which lists all packages build from + a PKGBUILD + - add --printsrcinfo flag to print SRCINFO file for a PKGBUILD + - record build information in a .BUILDINFO file + - add whirlpool to list of hashing options (FS#45859) + - makepkg-template: + - support multiple --template-dir + - added a testsuite + - repo-add: + - Always generate the .files database + - Only update database if the entire operation succeeds + - unarmored package signatures are rejected + - contrib: + - checkupdates: give error when fakeroot is missing + - checkupdates: provide packages versions in output + - checkupdates: fix failure in some locales (FS#40405) + - paccache: Add -q/--quiet + - pacdiff: do not require DIFFPROG for -o/--output (FS#46184) + - zsh_completion: updated to fix many missing options 4.2.1 - Remove warnings about incorrect directory ownership until packaging files with dynamic users/groups is improved - Do not require a specific automake version when building from -- 2.6.4

2 2

[pacman-dev] [PATCH] [RFC] alpm: Add a new hook type: PackageDir
by Olivier Brunel 01 Jan '16

01 Jan '16

Same as Package only instead of defining matching packages in the .hook file, it is done on the filesystem. Signed-off-by: Olivier Brunel <jjk(a)jjacky.com> --- Hey there, So I may be totally wrong, but I thought one of the cool things that could be done with hooks was that instead of having e.g. 3 packages refreshing a cache in their post_upgrade scriptlets, it'll be done via one post-transaction hook, so that it only runs once. And unless I'm missing something, this doesn't seem possible currently. At least not in a "good" way, since all matching packages must be included inside the .hook file itself. So am I wrong and was this never planned? Or is actually possible? Or is it meant to be added later? In case, here's a patch (though no documentation) that adds a new type of hooks: PackageDir Those are just like Package (and in fact turned into Package once validated/filled), only no targets should be featured inside the hook file itself, instead alpm will check for a directory by the hook name plus ".d" inside all the hookdirs (in order), so e.g. for hook "foobar" folders "foobar.d" will be looked for. Inside those dirs, a regular file means a target to add, said target being the name of the file. So files must be named after the packages to add/trigger the hook. A symlink however will mean to remove said package from the targets; The idea being that a user could create a symlink (to /dev/null) in e.g. /etc/pacman.d/hooks/foobar.d by the name of a package, to "undo"/mask a file by the same name in /usr/lib/alpm/hooks/foobar.d, file that could be part of any (other) package. That way, the font package provides the hook font-cache and any package that needs to trigger it simply adds an empty file to /usr/lib/alpm/hooks/font-cache.d by the name of the package. Also works for mkinitcpio providing a hook to rebuild the initramfs, which can then be triggered by any of e.g. mkinitcpio, linux, systemd, etc Thoughts? -j lib/libalpm/hook.c | 94 ++++++++++++++++++++++++++++++++++++++++++++++++++++-- 1 file changed, 91 insertions(+), 3 deletions(-) diff --git a/lib/libalpm/hook.c b/lib/libalpm/hook.c index b5ed17d..876beaf 100644 --- a/lib/libalpm/hook.c +++ b/lib/libalpm/hook.c @@ -37,6 +37,7 @@ enum _alpm_hook_op_t { enum _alpm_trigger_type_t { ALPM_HOOK_TYPE_PACKAGE = 1, + ALPM_HOOK_TYPE_PACKAGE_DIR, ALPM_HOOK_TYPE_FILE, }; @@ -95,12 +96,97 @@ static void _alpm_hook_free(struct _alpm_hook_t *hook) } } +static int _alpm_trigger_load_targets(alpm_handle_t *handle, + struct _alpm_trigger_t *trigger, char *hookname) +{ + int ret = 0; + size_t len = strlen(hookname); + alpm_list_t *i; + + for(i = handle->hookdirs; i && ret == 0; i = alpm_list_next(i)) { + int err; + char path[PATH_MAX]; + size_t dirlen = strlen(i->data); + struct dirent entry, *result; + DIR *d; + + if(dirlen + len + 3 >= PATH_MAX) { + _alpm_log(handle, ALPM_LOG_ERROR, _("could not open directory: %s: %s\n"), + (char *)i->data, strerror(ENAMETOOLONG)); + ret = -1; + break; + } + memcpy(path, i->data, dirlen); + memcpy(path + dirlen, hookname, len); + memcpy(path + dirlen + len, ".d/", 4); + + if(!(d = opendir(path))) { + if(errno == ENOENT) { + continue; + } else { + _alpm_log(handle, ALPM_LOG_ERROR, + _("could not open directory: %s: %s\n"), path, strerror(errno)); + ret = -1; + break; + } + } + + while((err = readdir_r(d, &entry, &result)) == 0 && result) { + struct stat buf; + + if(strcmp(entry.d_name, ".") == 0 || strcmp(entry.d_name, "..") == 0) { + continue; + } + + if(fstatat(dirfd(d), entry.d_name, &buf, 0) != 0) { + _alpm_log(handle, ALPM_LOG_ERROR, + _("could not stat file %s%s: %s\n"), path, entry.d_name, strerror(errno)); + ret = -1; + break; + } + + if(S_ISREG(buf.st_mode)) { + if(!alpm_list_find_str(trigger->targets, entry.d_name)) { + char *s; + STRDUP(s, entry.d_name, ret = -1; break); + trigger->targets = alpm_list_add(trigger->targets, s); + } + } else if(S_ISLNK(buf.st_mode)) { + char *s; + trigger->targets = alpm_list_remove_str(trigger->targets, entry.d_name, &s); + free(s); + } + } + + if(err != 0) { + _alpm_log(handle, ALPM_LOG_ERROR, _("could not read directory: %s: %s\n"), + (char *) i->data, strerror(errno)); + ret = -1; + } + + closedir(d); + } + + return ret; +} + static int _alpm_trigger_validate(alpm_handle_t *handle, - struct _alpm_trigger_t *trigger, const char *file) + struct _alpm_trigger_t *trigger, const char *file, char *hookname) { int ret = 0; - if(trigger->targets == NULL) { + if(trigger->type == ALPM_HOOK_TYPE_PACKAGE_DIR) { + trigger->type = ALPM_HOOK_TYPE_PACKAGE; + if(trigger->targets) { + ret = -1; + _alpm_log(handle, ALPM_LOG_ERROR, + _("Unexpected targets for PackageDir trigger in hook: %s\n"), file); + } else if(_alpm_trigger_load_targets(handle, trigger, hookname) < 0) { + ret = -1; + } + /* we allow no targets in this case, since e.g. they could have been + * "masked" by the user via symlinks */ + } else if(trigger->targets == NULL) { ret = -1; _alpm_log(handle, ALPM_LOG_ERROR, _("Missing trigger targets in hook: %s\n"), file); @@ -134,7 +220,7 @@ static int _alpm_hook_validate(alpm_handle_t *handle, } for(i = hook->triggers; i; i = i->next) { - if(_alpm_trigger_validate(handle, i->data, file) != 0) { + if(_alpm_trigger_validate(handle, i->data, file, hook->name) != 0) { ret = -1; } } @@ -297,6 +383,8 @@ static int _alpm_hook_parse_cb(const char *file, int line, } else if(strcmp(key, "Type") == 0) { if(strcmp(value, "Package") == 0) { t->type = ALPM_HOOK_TYPE_PACKAGE; + } else if(strcmp(value, "PackageDir") == 0) { + t->type = ALPM_HOOK_TYPE_PACKAGE_DIR; } else if(strcmp(value, "File") == 0) { t->type = ALPM_HOOK_TYPE_FILE; } else { -- 2.6.4

3 4

[pacman-dev] [PATCH] Use a bashism instead of mktemp's --tmpdir option.
by Alastair Hughes 31 Dec '15

31 Dec '15

I discovered that bacman and updpkgsums use --tmpdir while playing around in a busybox environment with pacman installed, as updpkgsums did not work. I've tested the attached patch in both that environment against pacman 4.2.1, and against a git checkout on a normal Arch system; both appear to work, but I may have misunderstood the reasoning behind using --tmpdir.

3 4