Pacman-dev

Download

pacman-dev@lists.archlinux.org

March 2017

6 participants
12 discussions

[pacman-dev] [PATCH] Ignore comments in INSTALL files (FS#51916)
by Michael Straube 04 Apr '17

04 Apr '17

If a comment in an INSTALL file contains the name of a valid INSTALL file function but the function itself is not present, pacman tries to execute that function. That leads to an error. Ignore comments in the grep function in libalpm/trans.c to avoid such erros. Signed-off-by: Michael Straube <straubem(a)gmx.de> --- lib/libalpm/trans.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/lib/libalpm/trans.c b/lib/libalpm/trans.c index 60114882..7689079b 100644 --- a/lib/libalpm/trans.c +++ b/lib/libalpm/trans.c @@ -305,6 +305,7 @@ void _alpm_trans_free(alpm_trans_t *trans) static int grep(const char *fn, const char *needle) { FILE *fp; + char *ptr; if((fp = fopen(fn, "r")) == NULL) { return 0; @@ -314,6 +315,9 @@ static int grep(const char *fn, const char *needle) if(safe_fgets(line, sizeof(line), fp) == NULL) { continue; } + if((ptr = strchr(line, '#')) != NULL) { + *ptr = '\0'; + } /* TODO: this will not work if the search string * ends up being split across line reads */ if(strstr(line, needle)) { -- 2.12.1

2 1

[pacman-dev] Non-existing user/group ownership and chroot
by Armin K. 06 Mar '17

06 Mar '17

Hi all. I'm using pacman for my LFS install, and as part of that, I also use hooks used by Arch for, say, systemd-sysusers, systemd-tmpfiles, etc. Some packages require that certain files/directories are owned by a certain user/group after install. This is somehow hard to achieve with .install file when systemd-sysuser hook is used (see [1] for an example). Since this is a LFS, it's "bootstrapped" from an already existing linux distro (doesn't have to be arch, it has its own temporary pacman). I use pacman -U -r /path/to/lfs to install packages from the host system. The issue I'm having is when an user isn't created and chown is ran in PKGBUILD's with statically assigned id's (ie, chown 20:20, where 20 will be an UID for the created user), pacman chowns those files/directories to something else entirely. I did however notice that on my host (Arch, of course), those missleading uids/gids correspond to the uids/gids of the users that are going to be created in LFS. So, if I have user/group named:named with uid:gid 20:20, and host system (Arch) has same user:group, with with uid:gid 40:40, the files that I explicitly chowned to 20:20 in PKGBUILD will be chown-ed to 40:40 instead when pacman -U -r ... is ran. So, how do I solve this problem? I suppose it's an issue in pacman -U with -r option. I can use chown 20:20 in .install file (before the user:groups have been created), and the file will be created with proper ownership. Thanks in advance. [1] https://bugs.archlinux.org/task/52680

3 12