On Thu, Feb 07, 2013 at 02:31:04PM +1000, Allan McRae wrote:
Dan/Dave,
I'd like comments on these patches - which at least to me are not obvious whether to include or not. A simple yes/no/fix would be good.
From patchwork:
* pacman: print version information in debug output https://patchwork.archlinux.org/patch/114/
Ack.
* removed duplicate macros SYMEXPORT and SYMHIDDEN from alpm_list.c, using them from util.h https://patchwork.archlinux.org/patch/304/
I'm siding with whatever Dan decides on this one.
* Remove "ts=2 sw=2" from Vim modelines for pacman-contrib https://patchwork.archlinux.org/patch/689/ (I think this was approved - Dan?)
No. We "enforce" ts/sw in pacman, why not contrib as well?
* Remove tab width config from Vim modelines in doc/ https://patchwork.archlinux.org/patch/690/ (I think this was approved - Dan?)
See above.
* Log if dbs are up to date, synced, or failed to sync https://patchwork.archlinux.org/patch/760/
No. Too noisy, not useful info.
* Move logging of sysupgrade start, add log when done https://patchwork.archlinux.org/patch/761/
See above.
* Exit with failure status if download or installation is not confirmed https://patchwork.archlinux.org/patch/876/
Ack.
From the days before patchwork...:
* Skip reading sync db deltas files if UseDelta is unset https://projects.archlinux.org/users/allan/pacman.git/commit/?h=working&id=7c4c418a
Makes sense. Ack.
* Quieten the build process some more https://projects.archlinux.org/users/allan/pacman.git/commit/?h=working&id=11046040
Ack.