15 Nov
2007
15 Nov
'07
12:01 p.m.
On Mon, Nov 12, 2007 at 08:01:02PM -0600, Dan McGee wrote:
I'd first like to say that I did this in the quickest way possible, so there is no guarantee I did everything right. I also did nothing to optimize for efficiency. In some cases, we could be calling the alpm_pkg_compute_requiredby() function way more than we should, because I basically replaced any call to alpm_pkg_get_requiredby() with a corresponding alpm_pkg_compute_requiredby() and free().
Should it be FREE(requiredby) or FREELIST(requiredby) ? It looks like in your patch submitted on the ML, FREE(requiredby) is used, but in the patch commited in git, FREELIST(requiredby) is used, except in one place : lib/libalpm/deps.c , can_remove_package line 585.