On 06/02/16 17:54, Alastair Hughes wrote:
makepkg -g no longer works on PKGBUILDs which do not include the current architecture due to a change in the 4.2.1 -> 5.0.0 cycle. I'm not sure how to approach the fix, so I've just made "makepkg -g" set the IGNOREARCH flag. Is this a reasonable approach?
I need to mull this over some more... but I am leaning towards yes.
The other option that I considered would be to move lint_pkgbuild to after GENINTEG is processed, but I think that having some sanity checking on the PKGBUILD's source array before downloading the sources would be helpful?
I agree - nothing should be done with a PKGBUILD that fails the checking.
On a related note, is there any tests for makepkg? I couldn't see any, but I may have missed something obvious. If so, then I could try to make a test for this case to ensure that it doesn't break again in the future.
There are no test cases. I started looking at this once, but was never sure how to best implement it. This is definitely something I want added if you are volunteering! Allan