[pacman-dev] [PATCH] libalpm: fix alpm_option_set_assumeinstalled

It looks like this function has never actually worked. The current list is never set to NULL after being freed. So the new deps were just appended to the already freed list, leading to a segfault. diff --git a/lib/libalpm/handle.c b/lib/libalpm/handle.c index e3193f40..23464045 100644 --- a/lib/libalpm/handle.c +++ b/lib/libalpm/handle.c @@ -690,6 +690,7 @@ int SYMEXPORT alpm_option_set_assumeinstalled(alpm_handle_t *handle, alpm_list_t if(handle->assumeinstalled) { alpm_list_free_inner(handle->assumeinstalled, (alpm_list_fn_free)alpm_dep_free); alpm_list_free(handle->assumeinstalled); + handle->assumeinstalled = NULL; } while(deps) { if(alpm_option_add_assumeinstalled(handle, deps->data) != 0) { -- 2.25.0