Re: [pacman-dev] [PATCH 2/5] signing: add ability to import keys using a WKD

On 2019-07-17 22:06, Jonas Witschel wrote:

+ if((gpg_err_code(gpg_err) == GPG_ERR_NO_ERROR) && (strcmp(key->subkeys->fpr, fpr) == 0)) {

Sorry, I just realised this will never be true because "fpr" comes from "parse_subpacket" and is always the 8 byte key ID, while "key->subkeys->fpr" is the full 20 byte fingerprint. We need to compare with "fpr" with "key->subkeys->keyid" instead, see attached for the corrected patch that also adds some more debugging output in case of a key mismatch.