On 01/10/13 21:18, Lukas Jirkovsky wrote:
On Tue, Oct 1, 2013 at 5:30 AM, Allan McRae <allan@archlinux.org> wrote:
I have not looked at the patch yet, but my initial impression is that the additional flag should not be needed. For non-vcs files, we extract the source over the top of whatever is in $srcdir. We should do the same for VCS sources.
Why may be worth having a flag for is to delete the source directory before starting: https://bugs.archlinux.org/task/17175
Other opinions here?
Allan
I don't mind doing that either. I just didn't want to change the existing behaviour because I thought that there is some reason to delete sources by default. I guess changing the default behaviour to what --incremental is supposed to do and fixing FS#17175 may be in fact simpler.
I guess the current delete source was due to me either building in a clean chroot or outside the source directory meaning it made no difference for me. I am happy with the default changing. Allan