Re: [pacman-dev] [PATCH] move db lock/unlock to the transaction functions

VMiklos wrote:

erm if we unlock the db in trans_release(), then we should call it in pacman_remove() even there isn't any error:

http://darcs.frugalware.org/darcsweb/darcsweb.cgi?r=pacman;a=plain_commitdif...;

Indeed, I noticed it right after applying your lock/unlock move patch. In fact, the trans_release call has always been missing, even before your patch (a transaction must be released, even if it happens to succeed!). Note that the same also applied to pacman_add, pacman_sync and pacman_deptest too. -- Aurelien