On Sat, Feb 1, 2014 at 4:40 PM, Guillaume Bouchard <guillaum.bouchard@gmail.com> wrote:
Hi,
On Sat, Feb 1, 2014 at 9:27 PM, Chirantan Ekbote <chirantan.ekbote@gmail.com> wrote:
When I tested this patch, it only seemed to work for adding and removing packages, there was no difference while performing upgrades. It looks like this is because the install reason for the upgraded package doesn't get set until commit_single_pkg(), which only runs after the user has confirmed the upgrade. Adding the line below makes the coloring work for upgrades as well.
From my tests, my changes works even during update.
I'm using alpm_pkg_get_reason of target->remove for upgrade and removal (because it is the obvious choice for removal, and in case of upgrade, I see that target->remove is correctly tagged).
Also, the patch no longer applies cleanly because of commit 3f34e09.
Indeed, I'll mail an updated patch now.
In my first patch, I proposed putting in bold the name of explicitly installed packages. This patch put in grey the name of "dependencies". Which one should we keep ?
Of the two options, I would prefer the dependencies to be shown in grey instead of having explicitly installed packages typeset in bold. I don't feel too strongly about this though, so I won't complain if everyone else prefers bold. Jason