19 Dec
2010
19 Dec
'10
3:05 a.m.
On 19/12/10 03:56, Dan McGee wrote: > On Fri, Dec 17, 2010 at 7:43 PM, Allan McRae<allan@archlinux.org> wrote: >> We use PATH_MAX everywhere by including limits.h so there is no >> point in doing a check for it in a different header when dealing >> with FreeBSD's libfetch. >> >> Signed-off-by: Allan McRae<allan@archlinux.org> > Looks fine, just two things I'll point out and let you decide how to > act on them: > 1. We check for limits.h but never use the macro shield anywhere, it > looks like. Probably common enough (and required by us anyway) that it > doesn't matter. It is a POSIX header, so no need for all that macro shield stuff. I'll kill the check. > 2. strings.h -> not used anywhere in libalpm, but still included in this list. I'll just kill it as part of this patch. Allan