On Tue, Dec 6, 2011 at 4:58 PM, Lukas Fleischer <archlinux@cryptocrack.de> wrote:
On Tue, Dec 06, 2011 at 04:38:41PM -0600, Dan McGee wrote:
On Tue, Dec 6, 2011 at 3:29 PM, Lukas Fleischer <archlinux@cryptocrack.de> wrote:
Can some autotools wizard please check if I broke anything here? `make distcheck` still looks good to me but I'm not 100% sure what I broke by adding all scripts to "bin_SCRIPTS" :)
Before: `make install` does not install contrib/. After: `make install` installs contrib/. So probably not what we want, at least recursively or by default. It would be nice that if you were actually in contrib, `make install` would do what one expected (and kill the ugly hardcoding of each script needed to currently install [1]). Autotools probably makes a setup like this a bitch though. Thoughts from anyone else?
How about removing "contrib" from "SUBDIRS" in our main Makefile.am and adding something like "DIST_SUBDIRS = $(SUBDIRS) contrib"? This way, contrib scripts won't be installed when running `make install` in the top level source directory but can be easily installed by running `make install` in "contrib/"...
The problem there is it completely stops make from descending in there, and as I've seen many times before (namely with docs), it gets ugly when I have to package it. I think you'd be out of luck because your Makefile wouldn't even be generated in there, and thus *.in never gets converted to the scripts and other files. -Dan