On Thu, 2016-09-29 at 21:39 +1000, Allan McRae wrote:
On 29/09/16 21:25, Gordian Edenhofer wrote:
On Thu, 2016-09-29 at 20:40 +1000, Dave Reisner wrote:
On Sep 29, 2016 06:23, "Gordian Edenhofer" <gordian.edenhofer@gma il.c om> wrote:
Reorganize scripts in contrib to fit the syntax and style of makepkg. Unify multiple different approaches to e.g. write a usage function, handle options and differences in naming schemas for options.
None of your changes which add gettext support are useful in their current form as you do not export TEXTDOMAIN or TEXTDOMAINDIR.
Thanks for the hint! I forgot about that. Btw. paclist [1] already defined it.
[1] https://git.archlinux.org/pacman.git/tree/contrib/paclist.sh.in #n23
It only works for paclist because it uses translations already provided by pacman. This will not work for anything else because strings from the contrib files are not added to the pacman translation.
A new translation domain for contrib needs set-up if this is to work.
Thanks for the explanation. To be honest I don't know how to setup a translation domain since I haven't read any documentation about this matter yet. I would appreciate if anybody could help me with this. Until then I will resumbit this patch as RFC once more and order commits according to whether they touch usage. An alternative approach would be to strip all gettext invocations and simply not make contrib script translatable.