On 25/01/15 07:26, Dave Reisner wrote:
On Jan 24, 2015 3:58 PM, "Christian Hesse" <list@eworm.de> wrote:
Dave Reisner <d@falconindy.com> on Sat, 2015/01/24 15:38:
+ if [[ $(file --brief --mime-type "$png") = 'image/png' ]]; then + optipng $OPTIPNGFLAGS "$png"
|| + warning "$(gettext "Could not optimize PNG image : %s")" "${png/$pkgdir\//}"
I really dislike that we're using a simple var instead of an array here. Is there a strong reason not to do this?
So you would prefer "${OPTIPNGFLAGS[@]}"? Again, this is adopted from upx and UPXFLAGS which is just a simple var.
I am fine with using an array, in fact I would prefer it. Want a new
&>/dev/null patch?
How about UPXFLAGS? Do we want to change it there?
I'd certainly prefer that but I don't know how others feel about breaking backwards compatibility.
Break it - I am sure no-one is using this functionality... And it matches our other variables like COMPRESSGZ. This should also be noted in the documentation. A.