Dan McGee wrote:
On Dec 9, 2007 3:54 AM, Allan McRae <allan.mcrae@qimr.edu.au> wrote:
Attached is a patch that fixes FS#7147. The query about upgrading pacman separately is not needed when the -p and -w flags are used. It is really only a one line patch...
I wasn't sure whether to use "alpm_trans_get_flags()" or "config->flags" as this seems to vary across files.
Allan
+ if(!(config->op_s_downloadonly) && !(alpm_trans_get_flags() & PM_TRANS_FLAG_PRINTURIS)) {
I would use alpm_trans_get_flags() here, so that is correct. However, both of these are trans flags, so you should be consistant. See PM_TRANS_FLAG_PRINTURIS and PM_TRANS_FLAG_DOWNLOADONLY.
-Dan
Sure. I was just sticking with what is used for the individual queries elsewhere in the same file. Updated patch attached. Allan