Re: [pacman-dev] [PATCH 1/3] makepkg: Move .PKGINFO creation into a function.

On Sun 21 Jun 2009 20:49 +1000, Allan McRae wrote:

Loui Chang wrote:

...

Signed-off-by: Loui Chang --- scripts/makepkg.sh.in | 24 ++++++++++++++---------- 1 files changed, 14 insertions(+), 10 deletions(-)

I'd like this to stay at the top of create_package as nameofpkg is also needed there. Then write_pkginfo can just be called with "write_pkginfo $nameofpkg"

...

if [ -z "$1" ]; then nameofpkg="$pkgname" else nameofpkg="$1" fi

The warning about license should be moved to the write_pkginfo function.

Alright another one is coming with those suggestions.