On 4/17/20 6:22 PM, Carson Black wrote:
This patch splits the monolithic 'Packages (count):' output on transactions into multiple package outputs per category of action: 'Installing (count):', 'Upgrading (count):', and 'Removing (count):'.
Signed-off-by: Carson Black <uhhadd@gmail.com>
This builds with warnings, which means that development builds including -Werror will fail. [1/4] Compiling C object 'pacman@exe/src_pacman_util.c.o' FAILED: pacman@exe/src_pacman_util.c.o ccache cc -Ipacman@exe -I. -I.. -Isrc/common -I../src/common -Ilib/libalpm -I../lib/libalpm -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Werror -std=gnu99 -g -Wcast-align -Wclobbered -Wempty-body -Wfloat-equal -Wformat-nonliteral -Wformat-security -Wignored-qualifiers -Wimplicit-fallthrough -Winit-self -Wlogical-op -Wmissing-declarations -Wmissing-field-initializers -Wmissing-parameter-type -Wmissing-prototypes -Wold-style-declaration -Woverride-init -Wpointer-arith -Wredundant-decls -Wshadow -Wsign-compare -Wstrict-aliasing -Wstrict-overflow=5 -Wstrict-prototypes -Wtype-limits -Wuninitialized -Wunused-but-set-parameter -Wunused-parameter -Wwrite-strings -include config.h -MD -MQ 'pacman@exe/src_pacman_util.c.o' -MF 'pacman@exe/src_pacman_util.c.o.d' -o 'pacman@exe/src_pacman_util.c.o' -c ../src/pacman/util.c ../src/pacman/util.c: In function ‘_display_targets’: ../src/pacman/util.c:901:25: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 901 | char *install_header = ""; | ^~ ../src/pacman/util.c:902:25: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 902 | char *upgrade_header = ""; | ^~ ../src/pacman/util.c:903:24: error: initialization discards ‘const’ qualifier from pointer target type [-Werror=discarded-qualifiers] 903 | char *remove_header = ""; | ^~ ../src/pacman/util.c:943:16: error: unused variable ‘target_name’ [-Werror=unused-variable] 943 | const char* target_name = alpm_pkg_get_name(target->remove); | ^~~~~~~~~~~ ../src/pacman/util.c:1010:21: error: comparison with string literal results in unspecified behavior [-Werror=address] 1010 | if (install_header != "") free(install_header); | ^~ ../src/pacman/util.c:1011:21: error: comparison with string literal results in unspecified behavior [-Werror=address] 1011 | if (upgrade_header != "") free(upgrade_header); | ^~ ../src/pacman/util.c:1012:20: error: comparison with string literal results in unspecified behavior [-Werror=address] 1012 | if (remove_header != "") free(remove_header); | ^~ cc1: all warnings being treated as errors -- Eli Schwartz Bug Wrangler and Trusted User