Dan McGee wrote:
From: Xavier Chantry <shiningxc@gmail.com>
This patch started as a simple typo fix (pugre instead of purge in two places), as well as a fix of a test which was using PURGE_TARGETS instead of $PURGE_TARGETS.
It evolved in a slight handling change of the OPTIONS which have a variable affecting their behavior (strip STRIP_DIRS, docs DOC_DIRS, zipman MAN_DIRS and purge PURGE_TARGETS), as well as a clarification in makepkg.conf. Now when a variable is undefined or empty, the corresponding option will have no effect. It looked weird to have a fallback when a option is defined but empty, it seems more natural to not have any fallbacks.
Also re-enable docs by default. It seems arbitrary to delete files from packages by default, and it would be more vanilla and distro agnostic to keep them. docs was also the only negated option.
Signed-off-by: Xavier Chantry <shiningxc@gmail.com>
I talked with Xavier about this last night and think it is a good and consistent way to handle all the options now available in makepkg.conf. And my spelling of "pugre" needs improving! I hadn't realized he actually went with the patch title I suggested... Xavier: I dont know how to split my patches now Xavier: I have typo fixes Xavier: documentation clarification Xavier: and a unimportant bugfix Xavier: and a rework of the OPTIONS handling Xavier: lol Allan: one big patch entitled "fix a lot of breakages caused by Allan" Xavier: sounds perfect