On Nov 19, 2007 5:31 AM, Nagy Gabor <ngaba@bibl.u-szeged.hu> wrote:
commit c244cfecf654d34032585530f00d68501ec63d77 Author: Dan McGee <dan@archlinux.org> Date: Mon Nov 12 23:01:14 2007 -0600
Move alpm_splitdep usage to db_read
Holy inefficient batman! For a pacman -Qt operation (when we are using compute_requiredby and not database entries), splitdep was being called ~1.3 million times on my local database. By splitting when we read the DB, we drop this number to around 1700 and save a LOT of time in doing so (a 5x increase in pacman -Qt speed here).
Note that the depends alpm_list_t in the package struct is no longer a string list, but a list of pmdepent_t objects.
Signed-off-by: Dan McGee <dan@archlinux.org> Small note: Storing pmdepend_t in pkgcache eats much more memory.
Static length strings are what really kill us, so that is where the effort should be focused. I believe Aaron is going to address this. -Dan