18 Oct
2018
18 Oct
'18
9:13 a.m.
On Thu, 18 Oct 2018 at 01:34, Andrew Gregory <andrew.gregory.8@gmail.com> wrote:
I wasn't concerned about the misleading message for this patch, but the failing test is another thing. If you're not testing your patches with `make check`, please do. We could update the test, but let's just go ahead and fix the "error" after all. I recommend, in a separate patch, adding a group_exists function and using that to distinguish between a non-existent group and a group with no packages selected after find_group_packages returns NULL.
I did say the patch set was incomplete ;) group_exists does seem like the best idea though so will do. Would you prefer that function be added to the backend or frontend?