On Thu, Oct 19, 2006 at 03:17:06PM +0200, VMiklos <vmiklos@frugalware.org> wrote:
thanks for doing it. a few comments (correct me if at some point i'm wrong):
a few more: 1) in alpm.i: -%pointer_cast(void *, long, void_to_long); +%pointer_cast(char *, long *, void_to_long); is this change a typo? 2) the _generated_ manpages are now under version control in /doc/man3. i think they should be cvs removed 3) in alpm.c: * @param level if true, then forces the update, otherwise update only in case - * the database isn't up to date * @param db pointer to the package database to update i think this is by accident, too 4) in alpm.c, too: -/** @defgroup alpm_conflict File Conflicts Functions +/** @defgroup alpm_dep File Conflicts Functions wtf? :) 5) alpm.h: - PM_ERR_MEMORY = 1, + PM_ERR_MEMORY = 2, i think this is just a workaround for the functions returning 1 instead of -1 on error. what about reverting this change, since as far as i see you've already fixed those problematic functions? 6) in alpm/db.c: if(db->path == NULL) { _alpm_log(PM_LOG_ERROR, _("malloc failed: could not allocate %d bytes"), - strlen(root)+strlen(dbpath)+strlen(treename)+2); + strlen(root)+strlen(dbpath)+strlen(treename)+2); FREE(db); RET_ERR(PM_ERR_MEMORY, NULL); } a) when i break a long line to shorter ones, then i indent the !=1st ones with 1 tab. vim automatically adds 2 ones. but why chaning the 2 tabs to 3 ones? b) please use tabs instead of 2 spaces (there are more than one example for this problem) 7) still in db.c: match = 1; + } else { } why adding such empty statements? (Judd's provides-related bugfix is still reverted) udv / greetings, VMiklos -- Developer of Frugalware Linux, to make things frugal - http://frugalware.org