On Thu, Nov 06, 2014 at 12:07:11AM +1000, Allan McRae wrote:
On 05/11/14 23:02, Dave Reisner wrote:
On Wed, Nov 05, 2014 at 10:59:00AM +1000, Allan McRae wrote:
On 04/11/14 23:10, Dave Reisner wrote:
--- scripts/makepkg.sh.in | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in index 86f8a77..9048676 100644 --- a/scripts/makepkg.sh.in +++ b/scripts/makepkg.sh.in @@ -2385,7 +2385,7 @@ extract_global_var() { array_build ref "$attr" [[ ${ref[@]} ]] && array_build "$outputvar" "$attr" else - [[ -v $attr ]] && printf -v "$outputvar" %s "${!attr}" + [[ ${!attr} ]] && printf -v "$outputvar" %s "${!attr}" fi }
Does this need pulled only when the SRCINFO patch goes in, or is it an independent change and thus needs a better commit title?
It's a real bug which exists in the code now, it just doesn't manifest itself until we leverage the code for SRCINFO generation.
I can resend with a different short desc.
No need to send - push to your branch and I will cherry-pick
Done -- force updated my 'bugfix' branch. d