On Nov 15, 2007 2:08 PM, Dan McGee <dpmcgee@gmail.com> wrote:
On Nov 15, 2007 1:21 PM, Aaron Griffin <aaronmgriffin@gmail.com> wrote:
On Nov 15, 2007 1:09 PM, Dan McGee <dpmcgee@gmail.com> wrote:
It is actually not a blank server, but a file:// URL which sets the server part to null or "" (hopefully, otherwise we could have a segfault here). Thus, only the path is set. I'm sure we can find a way to make this message more clear.
I noticed that later too...
http://code.phraktured.net/?p=pacman.git;a=commitdiff;h=c10aa2d7c9fd37a3f8f0...
Still, the original segfault remains.
Not to be nitpicky, but that could be a false test case (if the server name did not get set for some reason). Why not use strcmp(SCHEME_FILE, url->scheme)?
True and all but if there's no host name, and it's not a file url we shouldn't be at that point in the code Either way, I'll change it