Re: [pacman-dev] [PATCH 2/6] makepkg: use printf rather than echo to output variable

10 Mar 2012

On 10/03/12 01:20, Dave Reisner wrote:
...
On Fri, Mar 09, 2012 at 05:59:05PM +1000, Allan McRae wrote:
...
Signed-off-by: Allan McRae <allan@archlinux.org>
---
 scripts/makepkg.sh.in |   62 ++++++++++++++++++++++++-------------------------
 1 file changed, 31 insertions(+), 31 deletions(-)

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index 601c7e2..384e142 100644
<snip>
...
...
##
@@ -242,9 +242,9 @@ get_url() {
 get_full_version() {
  if [[ -z $1 ]]; then
      if [[ $epoch ]] && (( ! $epoch )); then
-			echo $pkgver-$pkgrel
+			printf "%s\n" $pkgver-$pkgrel
There's a few instances of these var expansions being unquoted. Can we
fix that while we're touching these lines?
Done, and throughout makepkg.  On my working branch.

Allan

    