Re: [pacman-dev] [PATCH 3/3] makepkg: fix pkgver() function not aborting on errors

13 Aug 2018

On Mon, 13 Aug 2018 21:20:58 -0400,
Eli Schwartz wrote:
...

diff --git a/scripts/makepkg.sh.in b/scripts/makepkg.sh.in
index bb24c633..1ab2ea3c 100644
--- a/scripts/makepkg.sh.in
+++ b/scripts/makepkg.sh.in
@@ -188,6 +188,9 @@ enter_fakeroot() {
 # Re-sources the PKGBUILD afterwards to allow for other variables that use $pkgver
 update_pkgver() {
  newpkgver=$(run_function_safe pkgver)
+	if (( $? != 0 )); then
+		error_function pkgver
+	fi
Why bring $? in to it, why not:

    if ! newpkgver=$(run_function_safe pkgver); then
        error_function pkgver
    fi

-- 
Happy hacking,
~ Luke Shumaker

    