On Sat, May 10, 2008 at 11:31 AM, Allan McRae <mcrae_allan@hotmail.com> wrote:
Removes a small TODO from the codebase
Signed-off-by: Allan McRae <mcrae_allan@hotmail.com> --- src/pacman/package.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/src/pacman/package.c b/src/pacman/package.c index 76e8e4f..6f4a195 100644 --- a/src/pacman/package.c +++ b/src/pacman/package.c @@ -245,8 +245,7 @@ void dump_pkg_changelog(pmpkg_t *pkg) void *fp = NULL;
if((fp = alpm_pkg_changelog_open(pkg)) == NULL) { - /* TODO after string freeze use pm_fprintf */ - fprintf(stderr, _("error: no changelog available for '%s'.\n"), + pm_fprintf(stderr, PM_LOG_ERROR, "no changelog available for '%s'.\n", Ooo, nice.
Any chance you want to fold this into a bigger patch, hopefully slightly tested, finding more of these types of things? This one wasn't alone. $ grep 'fprintf.*error' * | wc -l 41 Of course, this gives me second thoughts- we are using a libalpm defined logging constant in our front end application. should we be doing this?
alpm_pkg_get_name(pkg)); return; } else { -- 1.5.5.1
_______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://archlinux.org/mailman/listinfo/pacman-dev