9 Nov
2007
9 Nov
'07
8:55 p.m.
On Fri, Nov 09, 2007 at 08:54:52PM +0100, Nagy Gabor wrote:
Some more issues: 1. You simply forgot about resetting the tail pointer when you remove the last element with alpm_list_remove.
Yep, that's what explains the requiredby problem I noticed : http://www.archlinux.org/pipermail/pacman-dev/2007-November/009919.html Good catch :)
2. As I see, alpm_list_remove_node is used nowhere in the code, and dangerous (when you remove the first or last node, "interesting" things can happen); so that should be removed.
Oh right, I first thought the requiredby problem was caused by the issues you mentioned in remove_node (I thought remove used remove_node), but indeed, this function isn't used anywhere.