Xavier wrote:
On Mon, Mar 10, 2008 at 07:38:30PM -0500, Dan McGee wrote:
Wowzers! This is kind of cool on one hand, but pretty darn overkill for at least my typical use pattern. This would be awesome for something like a curses frontend though, I would say that. Anyone want to start developing? :)
If I was to critique it, I would agree that the column order should go old version, new version, size. But to be honest, I'm not too big on this patch so I probably wouldn't take it, unless there are a lot of people that have been looking for something like this. The addition of 140 lines of code doesn't exactly make me smile with joy, as I already think display_targets() is a rather gross function.
That's exactly what I was thinking. The output looks cool, but adding 140 lines to that part I already find messy isn't cool. If it was up to me, I would maybe just do one column based output, because I find the oldver and size informations useful.
_______________________________________________ pacman-dev mailing list pacman-dev@archlinux.org http://archlinux.org/mailman/listinfo/pacman-dev
Fair enough, my only goal is to get old version listed somewhere in the output if possible, since I would find that quite useful. So, I would be up for coding any ideas that would be acceptable to accomplish that. I am in agreement with what I think Xavier was saying, have just one output for upgrade which would be the columned output. This would eliminate the code clutter caused by adding in this option, but if I remember correctly, Dan you were against that before since you liked the current output.