Travis Willard wrote:
On Sat, May 17, 2008 at 3:54 PM, Xavier<shiningxc@gmail.com> wrote:
That's interesting. We don't really enforce anything with the prototypes but it's good to show the preferred syntax with them.
I think $pkgname and $pkgver should be safe though, right? They shouldn't contain spaces or other weird things so don't require additional quotings. But pkgdir, srcdir and startdir do.
So maybe instead of : cd "$srcdir/$pkgname-$pkgver" we could use : cd ${srcdir}/$pkgname-$pkgver
Well, ${srcdir} still needs the quotes.
"${srcdir}/$pkgname-$pkgver"
Ok what I said was stupid, forget it :) Another thing I just found out, suppose you are in a directory with a space, the following doesn't work in bash but it does work with zsh: startdir=$(pwd); cd $startdir For some reasons, zsh doesn't seem to need any quoting.. Weird stuff.