On Thu, May 02, 2013 at 06:28:51AM +0200, Jan Alexander Steffens wrote:
On Thu, May 2, 2013 at 5:56 AM, Allan McRae <allan@archlinux.org> wrote:
On 02/05/13 13:44, William Giokas wrote:
-if (( ! PKGVERFUNC )); then +if (( ! PKGVERFUNC && ! VERIFYSOURCE )); then check_build_status fi
Fine.
I think this should probably be done in the check_build_status function just to mirror NOBUILD.
I honestly don't mind. Either way works. Allan, which one do you prefer?
-if (( NODEPS || (NOBUILD && !DEP_BIN ) )); then +if (( VERIFYSOURCE || NODEPS || (NOBUILD && !DEP_BIN ) )); then # no warning message needed for nobuild if (( NODEPS )); then warning "$(gettext "Skipping dependency checks.")"
I have been thinking about this... Your VCS tool will be in makedepends and needed to download those sources.
Wouldn't it be cleaner if makepkg would handle the "sourcedeps" itself? I wouldn't want to install loads of unneeded makedepends on my chrootbuild host just to get git.
I've fixed this, when there's a decision where the first bit should go, then I'll submit this again. Thanks, -- William Giokas | KaiSforza GnuPG Key: 0x73CD09CF Fingerprint: F73F 50EF BBE2 9846 8306 E6B8 6902 06D8 73CD 09CF