On 1/16/20 12:42 PM, Saul Tigh wrote:
I re-submitted the patch with 'git send-email' to comply with the rules.
Thanks, your v2 patch no longer returns an error claiming it is corrupted. :)
As to user management, none exists at that stage. The system is absolutely bare however I think the root privilege is needed at that stage and is not just a question of changing user ID.
Wouldn't it make more sense in that case to add a build system switch e.g. meson -Dmakepkg-asroot=enabled? I'm concerned about including a codepath that doesn't do anything unless you know it exists and patch the source to use it.
That is a valid point. I have to do more research about meson build system as I'm not familiar with it much and will try to re-submit a new patch with your suggestion. Has pacman moved away from autotools completely and do things with meson?
Most likely you'd want to take a look at build-aux/edit-script.sh.in, and the "substs" dictionary of replacements in meson.build -- you can add options to meson_options.txt autotools is still supported, and I'd advise adding options to both meson and autotools -- the plan is to deprecate autotools soon, but until it's actually removed, we should probably try to make them both behave the same. :D Feel free to ask any questions about implementing changes in meson. -- Eli Schwartz Bug Wrangler and Trusted User