On Fri, Jul 25, 2008 at 6:42 AM, Xavier <shiningxc@gmail.com> wrote:
On Fri, Jul 25, 2008 at 5:20 AM, Dan McGee <dpmcgee@gmail.com> wrote:
I will send a few patches from my working branch here for review, but does anyone have objections to anything I've included on it? If not, this will all go to master with a 3.2.0 tag soon to follow. http://code.toofishes.net/gitweb.cgi?p=pacman.git;a=shortlog;h=refs/heads/wo...
Well, the only thing I see is my two display_targets patches breaking gettext strings : http://code.toofishes.net/gitweb.cgi?p=pacman.git;a=commitdiff;h=dfae7bdd524... "Targets:" -> "Targets (%d):" "Remove:" -> "Remove (%d):" Ha, I hadn't even realized this. Oops. Can you mark your patches [PATCH/3.2] or [PATCH/future] or something next time? I wanted to ask you which patches were for what, but you were sleeping obviously.
http://code.toofishes.net/gitweb.cgi?p=pacman.git;a=commitdiff;h=8877c88defd... "\nDo you want to remove these packages?" -> "Do you want to remove these packages?"
However, as you can see, these 3 changes can easily be replicated to every translations by anyone. If you also think these patches are a good idea for the 3.2 release, I can do the necessary translation changes.
Is it worth it, or just wait for 3.2.1? Up to you, but if we want to do this now I need someone else to write the patch. -Dan