On 04/06/19 at 04:43pm, Nathan Aclander wrote:
I'm fairly new to using git send-email, so I wasn't sure how to add an explanation to the patch while cleanly separating it from the git commit message. I can speak more to why I found it useful.
Use --annotate and put comments you don't want to end up in the log between the diff stats and the first 'diff --git' line: --- doc/pacman.conf.5.asciidoc | 3 +++ 8 files changed, 24 insertions(+), 1 deletion(-) <--- Comments go here. diff --git a/doc/pacman.conf.5.asciidoc b/doc/pacman.conf.5.asciidoc
While I was traveling, certain mirrors became unreachable, or extremely slow. I had to wait 10 seconds not only for each repo, but then again every time pacman would try and download an individual package. Since this was set at 10 seconds by default, the wait time was far too long. I wanted to change it to 1 second so that pacman would move on to the next mirror faster.
Using this patch seemed more usable for me than to having to comment out mirrors manually depending my network conditions. Are you concerned that having this parameter be tunable would cause pacman.conf to be too complex?
More or less, yes. We don't want to have to implement every single option that libcurl provides in pacman, so we try to require a fairly compelling justification before adding them. We are not against making network operations more configurable, though. In fact, we would like to get rid of the external downloader, but can't because some people need specific settings that we don't, and never will, expose directly. So, if you, or anybody else, can come up with a more general solution that doesn't require us to add dozens of options to pacman.conf, we'd love to hear it.