On 9/11/22 19:15, brainpower wrote:
Am 09.11.22 um 03:13 schrieb Allan McRae:
@Andrew (or anyone): the main patch I'd like another set of eyes on is: "Add sandboxed download for the internal downloader".
I've read it over and it looks mostly good to me. I did not build or test, just read the code.
Two things I noticed are:
- The "sandboxing failed" log message is a lot nicer in [1] than in [2] (line 995 in dload.c), maybe they should match?
Thanks - I have unified these messages.
- Also, the `done = true` before the break in the first loop of the parent might be redundant (line 1026 in dload.c [3]), since `done` isn't used after the loop. Maybe even all `done=true` could be breaks, as no loop code runs after them anyway?
In fact, that whole while loop looks weird to me. Do we need one here? It looks like if the read() call fails, we bail. Then only bail if we processed that call correctly? Weird... Allan