On Thu, May 29, 2008 at 10:42 PM, Allan McRae <mcrae_allan@hotmail.com> wrote:
Dan McGee wrote:
One currently known issue I am working on: my versioncmp change a while back definitely broke something, and I've written a short vercmp test script that I plan on incorporating into our codebase. You can see that on my working branch.
You probably should add the mirror cases for these -1 return situations.
+# with pkgrel, simple +runtest 1.5.0-1 1.5.0-1 0 +runtest 1.5.0-1 1.5.0-2 -1 +runtest 1.5.0-1 1.5.1-1 -1 +runtest 1.5.0-2 1.5.1-1 -1 + +# with pkgrel, mixed lengths +runtest 1.5-1 1.5.1-1 -1 +runtest 1.5-2 1.5.1-1 -1 +runtest 1.5-2 1.5.1-2 -1
I've been bitten by bugs not picked up because of missing test cases too many times in the past not to include them.
I know what you mean. I've already added another two test cases tonight after I got all the existing ones to pass and there were still problems. :) I made this script super easy to add test cases to though, so no real excuse to not include them. -Dan