Re: [pacman-dev] [PATCH 2/2] makepkg: enforce fakeroot usage

On Sat, Mar 8, 2014 at 5:17 AM, Allan McRae wrote:

On 08/03/14 21:11, Allan McRae wrote:

...

Packaging outside of fakeroot can result in incorrect permissions for package files. It has been years since fakeroot issues during packaging were common, so it is safe to enforce fakeroot usage. If using fakeroot is impossible for some reason, a two line wrapper script will suffice to fool makepkg.

Signed-off-by: Allan McRae --- doc/makepkg.conf.5.txt | 5 +---- etc/makepkg.conf.in | 5 ++--- scripts/makepkg.sh.in | 59 ++++++++++---------------------------------------- 3 files changed, 15 insertions(+), 54 deletions(-)

This and the remove --asroot patch are a RFC. Both these options are not needed, and removing them significantly reduces code complexity.

+1 from me, this looks vastly simplified now. -Dan