Sebastian Nowicki wrote:
Yes, it would be nice if all of them were documented. But none of them are.
I'm not trying to solve every existing problem with the pacman source. I'm just trying to add a new feature without making the code any 'worse' than it was ...
And to be honest, I would be happy to add this documentation, but ... I've already constructed and re-constructed my git patches so many times to satisfy requests on this list, I'm afraid I have no more energy to do it all over again just to add some comments in a place where no comments existed previously. Sorry :(
I wasn't talking about fixing any problems, but rather not creating more. I only suggested that you document the field that you added, so that there would be less to document in the future. If everyone were to document code when they modify/add it, the documentation would slowly improve. I'm not a developer so my nitpicking can be safely ignored :P.
I suppose it's how you look at it. If I modify a block of code that already has comments, I add comments to my changes. If I modify a block of code that does not have comments, then I don't. Someone decided originally that the block in question didn't need comments, so I just followed that lead. If I have to re-create my patches again, then I'll put the comments in there as part of that. Thanks, Bryan