2007/3/28, Dan McGee <dpmcgee@gmail.com>:
I've inlined it so I can comment on it. Comments are near whatever I have a comment on. :)
+. gettext.sh + +TEXTDOMAIN=makepkg ...
Can you smash this stuff into one block with a nice comment like "# gettext initialization"? And it might be more clear to use 'source' instead of '.' for consistency with the rest of makepkg.
Done.
@@ -98,6 +105,7 @@ error() { if [ ! "$USE_COLOR" = "n" -a "$(check_buildenv color)" = "y" ]; then echo -e "\033[1;31m==> ERROR:\033[1;0m \033[1;1m$1\033[1;0m" >&2 else + error=$1 echo "==> ERROR: $1" >&2
What is this for? It is the only function that got changed, is it debug code?
My mistake, sorry. I deleted it.
@@ -177,6 +185,9 @@ in_array() { }
checkdeps() { + local missdep="" + local deplist="" +
I think this is old code, along with a few of the things below. Try to sync with the latest in CVS or GIT.
Done.
+echo "$(eval_gettext "# Generated by makepkg \$myver")" >.PKGINFO
Leave this one out of gettext- its a debug message and goes into the package itself.
Done. In attachment new makepkg with the latest code in CVS. Let'me know if it's OK now. Also I generated now an initial makepkg.pot file (116 messages). If you want, you can generate the makepkg.pot with this command: xgettext --language=Shell makepkg -o makepkg.pot -- Giovanni Scafora Arch Linux Trusted User (voidnull) http://www.archlinux.org linuxmania@gmail.com