Eric Bélanger wrote:
On Tue, Nov 3, 2009 at 7:26 AM, Cedric Staniewski <cedric@gmx.ca> wrote:
Eric Bélanger wrote:
On Tue, Nov 3, 2009 at 12:59 AM, Allan McRae <allan@archlinux.org> wrote:
Dan McGee wrote:
On Mon, Nov 2, 2009 at 11:00 PM, Eric Bélanger <snowmaniscool@gmail.com> wrote:
When DESTDIR is used, symlinks to the packages will be put in the build directory. This combines the convenience of a global package cache with the ease of having a package (i.e. a symlink) in the build directory for testing and installation purpose.
I really like your idea of having a symlink to the package. Regarding the patch, I think we should stick with the "new" coding style and also merge the two if statements; could look like this:
if (( ! ret )) && [[ $PKGDEST != $startdir ]]; then ln -sf "${pkg_file/$EXT/$PKGEXT}" "$pkglinks_target" ret=$? fi
I was just following the current style of the function I was working in. Allan, Dan: is the above coding style OK with you?
Yes, there is going to be a massive patch integrated at some stage that converts [ style tests to [[ style tests. All patches waiting for makepkg are currently sitting on my working branch and I will rebase them and adjusts any tests to this style before they go into the main git repo. This just saves me work. I really should check how that patch is progressing... Allan